public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/92177] [10 regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
@ 2020-05-01 15:16 ` ro at gcc dot gnu.org
2020-05-01 15:17 ` ro at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: ro at gcc dot gnu.org @ 2020-05-01 15:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47085|0 |1
is obsolete| |
--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 48429
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48429&action=edit
32-bit sparc-sun-solaris2.11 bb-slp-22.c.171.slp2
I just noticed that the test still FAILs, both 32 and 64-bit, and apparently
never stopped.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10 regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
2020-05-01 15:16 ` [Bug tree-optimization/92177] [10 regression] gcc.dg/vect/bb-slp-22.c FAILs ro at gcc dot gnu.org
@ 2020-05-01 15:17 ` ro at gcc dot gnu.org
2020-05-04 14:14 ` [Bug tree-optimization/92177] [10/11 " jakub at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: ro at gcc dot gnu.org @ 2020-05-01 15:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> ---
Not yet fixed.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10/11 regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
2020-05-01 15:16 ` [Bug tree-optimization/92177] [10 regression] gcc.dg/vect/bb-slp-22.c FAILs ro at gcc dot gnu.org
2020-05-01 15:17 ` ro at gcc dot gnu.org
@ 2020-05-04 14:14 ` jakub at gcc dot gnu.org
2020-05-04 16:08 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-05-04 14:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
Summary|[10 regression] |[10/11 regression]
|gcc.dg/vect/bb-slp-22.c |gcc.dg/vect/bb-slp-22.c
|FAILs |FAILs
Priority|P1 |P2
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Doesn't look like a release blocker though, it seems this isn't a wrong-code
issue.
sparc*-*-solaris* is not a vect_int_mult target, as it can't vectorize integer
multiplication, but on the testcase in question it doesn't vectorize that:
[bb-slp-22.c:29:24] _5 = x_48(D) + 1;
[bb-slp-22.c:29:19] _6 = _5 * a0_44;
- [bb-slp-22.c:29:14] [bb-slp-22.c:29:10] out[0] = _6;
[bb-slp-22.c:30:24] _7 = y_49(D) + 1;
[bb-slp-22.c:30:19] _8 = _7 * a1_45;
- [bb-slp-22.c:30:14] [bb-slp-22.c:30:10] out[1] = _8;
[bb-slp-22.c:31:19] _9 = _5 * a2_46;
- [bb-slp-22.c:31:14] [bb-slp-22.c:31:10] out[2] = _9;
[bb-slp-22.c:32:19] _10 = _7 * a3_47;
- [bb-slp-22.c:32:14] [bb-slp-22.c:32:10] out[3] = _10;
+ _70 = {_9, _10};
+ [bb-slp-22.c:29:14] vect_cst__71 = _70;
+ _72 = {_6, _8};
+ [bb-slp-22.c:29:14] vect_cst__73 = _72;
+ [bb-slp-22.c:29:14] MEM <vector(2) unsigned int> [(unsigned int *)&out] =
vect_cst__73;
+ [bb-slp-22.c:29:14] _75 = &[bb-slp-22.c:29:10] out[0] + 8;
+ [bb-slp-22.c:29:14] MEM <vector(2) unsigned int> [(unsigned int *)_75] =
vect_cst__71;
It just vectorizes the stores. So looks like a testsuite issue to me. Either
it needs to look for a different message in the dump file etc.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10/11 regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-05-04 14:14 ` [Bug tree-optimization/92177] [10/11 " jakub at gcc dot gnu.org
@ 2020-05-04 16:08 ` rguenth at gcc dot gnu.org
2020-05-05 13:09 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (5 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-04 16:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |ASSIGNED
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
The SLP reorgs made making this testcase target agnostic really really hard.
It was supposed to test multiplication vectorization but now tests nothing. I
don't see how to reliably test this unless we scan for details in the
vectorizer
dumps that are prone to change. Currently we have for example
on x86_64:
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
SLPing BB part
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
------>vectorizing SLP node starting from: _5 = x_48(D) + 1;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand x_48(D), type of def: external
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand 1, type of def: constant
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
transform binary/unary operation.
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
created new init_stmt: vect_cst__63 = _42;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
created new init_stmt: vect_cst__12 = { 1, 1, 1, 1 };
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
add new stmt: vect__5.19_13 = vect_cst__63 + vect_cst__12;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
------>vectorizing SLP node starting from: _6 = _5 * a0_44;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand x_48(D) + 1, type of def: internal
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: vectype vector(4) unsigned int
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand _1 + 23, type of def: external
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
transform binary/unary operation.
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
created new init_stmt: vect_cst__71 = _70;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
add new stmt: vect__6.20_72 = vect__5.19_13 * vect_cst__71;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
------>vectorizing SLP node starting from: out[0] = _6;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand _5 * a0_44, type of def: internal
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: vectype vector(4) unsigned int
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand _7 * a1_45, type of def: internal
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand _5 * a2_46, type of def: internal
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vect_is_simple_use: operand _7 * a3_47, type of def: internal
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
transform store. ncopies = 1
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
create vector_type-pointer variable to type: vector(4) unsigned int
vectorizing a pointer ref: out[0]
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
created &out[0]
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
add new stmt: MEM <vector(4) unsigned int> [(unsigned int *)&out] =
vect__6.20_72;
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14: note:
vectorizing stmts using SLP.
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/bb-slp-22.c:35:14:
optimized: basic block part vectorized using 16 byte vectors
we could match 'vectorizing SLP node starting from: _6 = _5 * a0_44;
which means we are actually vectorizing a multiplication. Like with
the following. Rainer - can you test this?
diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-22.c
b/gcc/testsuite/gcc.dg/vect/bb-slp-22.c
index 6dc2375f5d1..f25a225666e 100644
--- a/gcc/testsuite/gcc.dg/vect/bb-slp-22.c
+++ b/gcc/testsuite/gcc.dg/vect/bb-slp-22.c
@@ -63,6 +63,6 @@ int main (void)
return 0;
}
-/* { dg-final { scan-tree-dump-times "basic block vectorized" 1 "slp2" {
target { ! {vect_int_mult } } } } } */
-/* { dg-final { scan-tree-dump-times "basic block vectorized" 2 "slp2" {
target vect_int_mult } } } */
+/* { dg-final { scan-tree-dump-times "basic block vectorized" 2 "slp2" } } */
+/* { dg-final { scan-tree-dump "vectorizing SLP node starting from: _\[0-9\]+
= _\[0-9\]+ \\\* a0" "slp2" { target vect_int_mult } } } */
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10/11 regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-05-04 16:08 ` rguenth at gcc dot gnu.org
@ 2020-05-05 13:09 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-05-05 13:41 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2020-05-05 13:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
[...]
> which means we are actually vectorizing a multiplication. Like with
> the following. Rainer - can you test this?
[...]
Works for me: tested on sparc-sun-solaris2.11 (32 and 64-bit) and (to
verify that I didn't mess up the mangled patch) on i386-pc-solaris2.11.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10/11 regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2020-05-05 13:09 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2020-05-05 13:41 ` cvs-commit at gcc dot gnu.org
2020-05-05 13:41 ` [Bug tree-optimization/92177] [10 Regression] " rguenth at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-05 13:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:3fbf43b9bc060e2904abe64e870868b9a4bfce13
commit r11-71-g3fbf43b9bc060e2904abe64e870868b9a4bfce13
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 5 15:38:24 2020 +0200
testsuite/92177 - adjust expected patterns for gcc.dg/vect/bb-slp-22.c
We now always vectorize two BBs, adjust the selector to also scan
for integer multiplication vectorization explicitely.
2020-05-05 Richard Biener <rguenther@suse.de>
PR testsuite/92177
* gcc.dg/vect/bb-slp-22.c: Adjust.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10 Regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2020-05-05 13:41 ` cvs-commit at gcc dot gnu.org
@ 2020-05-05 13:41 ` rguenth at gcc dot gnu.org
2020-05-07 11:56 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-05 13:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |10.0
Summary|[10/11 regression] |[10 Regression]
|gcc.dg/vect/bb-slp-22.c |gcc.dg/vect/bb-slp-22.c
|FAILs |FAILs
Known to work| |11.0
--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk (hopefully).
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10 Regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2020-05-05 13:41 ` [Bug tree-optimization/92177] [10 Regression] " rguenth at gcc dot gnu.org
@ 2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-05-13 7:12 ` rguenth at gcc dot gnu.org
2020-05-13 7:20 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-05-07 11:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.0 |10.2
--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.1 has been released.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10 Regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2020-05-07 11:56 ` jakub at gcc dot gnu.org
@ 2020-05-13 7:12 ` rguenth at gcc dot gnu.org
2020-05-13 7:20 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-13 7:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/92177] [10 Regression] gcc.dg/vect/bb-slp-22.c FAILs
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2020-05-13 7:12 ` rguenth at gcc dot gnu.org
@ 2020-05-13 7:20 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-13 7:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92177
--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:ff9d4e09566e24d4dff10adeaef109823266c7bd
commit r10-8140-gff9d4e09566e24d4dff10adeaef109823266c7bd
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 5 15:38:24 2020 +0200
testsuite/92177 - adjust expected patterns for gcc.dg/vect/bb-slp-22.c
We now always vectorize two BBs, adjust the selector to also scan
for integer multiplication vectorization explicitely.
2020-05-05 Richard Biener <rguenther@suse.de>
PR testsuite/92177
* gcc.dg/vect/bb-slp-22.c: Adjust.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-05-13 7:20 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-92177-4@http.gcc.gnu.org/bugzilla/>
2020-05-01 15:16 ` [Bug tree-optimization/92177] [10 regression] gcc.dg/vect/bb-slp-22.c FAILs ro at gcc dot gnu.org
2020-05-01 15:17 ` ro at gcc dot gnu.org
2020-05-04 14:14 ` [Bug tree-optimization/92177] [10/11 " jakub at gcc dot gnu.org
2020-05-04 16:08 ` rguenth at gcc dot gnu.org
2020-05-05 13:09 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-05-05 13:41 ` cvs-commit at gcc dot gnu.org
2020-05-05 13:41 ` [Bug tree-optimization/92177] [10 Regression] " rguenth at gcc dot gnu.org
2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-05-13 7:12 ` rguenth at gcc dot gnu.org
2020-05-13 7:20 ` cvs-commit at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).