public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather
       [not found] <bug-92216-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-16 16:35 ` ibuclaw at gcc dot gnu.org
  2020-03-16 22:06 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: ibuclaw at gcc dot gnu.org @ 2020-03-16 16:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92216

ibuclaw at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ibuclaw at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-03-16

--- Comment #2 from ibuclaw at gcc dot gnu.org ---
Hi Daniel,

Thanks for the patch, however instead I've gone with just marking the thunks as
non-public.  This is because the body generated for such thunks is different
from the case where the thunk and target function are in the same compilation
unit.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather
       [not found] <bug-92216-4@http.gcc.gnu.org/bugzilla/>
  2020-03-16 16:35 ` [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather ibuclaw at gcc dot gnu.org
@ 2020-03-16 22:06 ` cvs-commit at gcc dot gnu.org
  2020-03-16 22:28 ` ibuclaw at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-03-16 22:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92216

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:447d196e75d97a9ac7c6a548dc9d0fe367adf6be

commit r10-7199-g447d196e75d97a9ac7c6a548dc9d0fe367adf6be
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Mon Mar 16 23:04:49 2020 +0100

    d: Fix multiple definition error when using mixins and interfaces.

    gcc/d/ChangeLog:

            PR d/92216
            * decl.cc (make_thunk): Don't set TREE_PUBLIC on thunks if the
target
            function is external to the current compilation.

    gcc/testsuite/ChangeLog:

            PR d/92216
            * gdc.dg/imports/pr92216.d: New.
            * gdc.dg/pr92216.d: New test.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather
       [not found] <bug-92216-4@http.gcc.gnu.org/bugzilla/>
  2020-03-16 16:35 ` [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather ibuclaw at gcc dot gnu.org
  2020-03-16 22:06 ` cvs-commit at gcc dot gnu.org
@ 2020-03-16 22:28 ` ibuclaw at gcc dot gnu.org
  2020-05-18  9:07 ` oss at cogitri dot dev
  2020-05-18 13:19 ` cvs-commit at gcc dot gnu.org
  4 siblings, 0 replies; 5+ messages in thread
From: ibuclaw at gcc dot gnu.org @ 2020-03-16 22:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92216

ibuclaw at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from ibuclaw at gcc dot gnu.org ---
Fix committed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather
       [not found] <bug-92216-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2020-03-16 22:28 ` ibuclaw at gcc dot gnu.org
@ 2020-05-18  9:07 ` oss at cogitri dot dev
  2020-05-18 13:19 ` cvs-commit at gcc dot gnu.org
  4 siblings, 0 replies; 5+ messages in thread
From: oss at cogitri dot dev @ 2020-05-18  9:07 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92216

Rasmus Thomsen <oss at cogitri dot dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oss at cogitri dot dev

--- Comment #5 from Rasmus Thomsen <oss at cogitri dot dev> ---
*** Bug 95184 has been marked as a duplicate of this bug. ***

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather
       [not found] <bug-92216-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2020-05-18  9:07 ` oss at cogitri dot dev
@ 2020-05-18 13:19 ` cvs-commit at gcc dot gnu.org
  4 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-18 13:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92216

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:3e84ee0fab9cedfa57fe86ea3c00608f6a873ab9

commit r9-8603-g3e84ee0fab9cedfa57fe86ea3c00608f6a873ab9
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Mon Mar 16 23:04:49 2020 +0100

    d: Fix multiple definition error when using mixins and interfaces.

    gcc/d/ChangeLog:

            PR d/92216
            * decl.cc (make_thunk): Don't set TREE_PUBLIC on thunks if the
target
            function is external to the current compilation.

    gcc/testsuite/ChangeLog:

            PR d/92216
            * gdc.dg/imports/pr92216.d: New.
            * gdc.dg/pr92216.d: New test.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-18 13:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-92216-4@http.gcc.gnu.org/bugzilla/>
2020-03-16 16:35 ` [Bug d/92216] GDC generate duplicate symbols when mixins and interfaces are used to gather ibuclaw at gcc dot gnu.org
2020-03-16 22:06 ` cvs-commit at gcc dot gnu.org
2020-03-16 22:28 ` ibuclaw at gcc dot gnu.org
2020-05-18  9:07 ` oss at cogitri dot dev
2020-05-18 13:19 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).