public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/92472] enhancement: 5 * constify some parameters
Date: Wed, 06 May 2020 15:23:36 +0000	[thread overview]
Message-ID: <bug-92472-4-0dB0SbIacS@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-92472-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92472

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to David Binderman from comment #10)
> > It certainly has an effect on which member functions you can call on the
> > parameter.
> 
> Agreed, but does it matter ? These are a bunch of comparison
> functions, they AFAIK shouldn't be changing the objects they are comparing.

You're confused. It's irrelevant whether the comparison function changes
anything, and that's not what cppcheck was complaining about anyway.

It was talking about the parameters to operator< and you didn't change that in
your patch. My comment was saying that *if* you had change what cppcheck was
complaining about, it would have been wrong for a different reason (that you
can't call operator* if the parameters are const).

> I am still not sure if the new code is ok or not,

Wasn't "This is 400% wrong" clear?

> Suggest play safe and assume that JW is correct, so the proposed change to
> file
> multiway_merge.h should be removed.

It already has been.

> If this code is to die, should it be marked as unmaintained ?

What does that mean?

  parent reply	other threads:[~2020-05-06 15:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-92472-4@http.gcc.gnu.org/bugzilla/>
2020-05-05 13:59 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:00 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:01 ` marxin at gcc dot gnu.org
2020-05-06 10:07 ` redi at gcc dot gnu.org
2020-05-06 10:55 ` dcb314 at hotmail dot com
2020-05-06 14:00 ` redi at gcc dot gnu.org
2020-05-06 14:08 ` redi at gcc dot gnu.org
2020-05-06 15:08 ` dcb314 at hotmail dot com
2020-05-06 15:23 ` redi at gcc dot gnu.org [this message]
2020-05-06 15:30 ` redi at gcc dot gnu.org
2020-05-07 20:43 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-92472-4-0dB0SbIacS@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).