public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/92978] std::gcd mishandles mixed-signedness Date: Wed, 02 Sep 2020 16:32:30 +0000 [thread overview] Message-ID: <bug-92978-4-ZBPjFmoxmz@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-92978-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92978 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:31782bd45331ef3006f624d7b1cc9cd11b4abb84 commit r10-8703-g31782bd45331ef3006f624d7b1cc9cd11b4abb84 Author: Jonathan Wakely <jwakely@redhat.com> Date: Fri Aug 28 22:45:24 2020 +0100 libstdc++: Fix std::gcd and std::lcm for unsigned integers [PR 92978] This fixes a bug with mixed signed and unsigned types, where converting a negative value to the unsigned result type alters the value. The solution is to obtain the absolute values of the arguments immediately and to perform the actual GCD or LCM algorithm on two arguments of the same type. In order to operate on the most negative number without overflow when taking its absolute, use an unsigned type for the result of the abs operation. For example, -INT_MIN will overflow, but -(unsigned)INT_MIN is (unsigned)INT_MAX+1U which is the correct value. libstdc++-v3/ChangeLog: PR libstdc++/92978 * include/std/numeric (__abs_integral): Replace with ... (__detail::__absu): New function template that returns an unsigned type, guaranteeing it can represent the most negative signed value. (__detail::__gcd, __detail::__lcm): Require arguments to be unsigned and therefore already non-negative. (gcd, lcm): Convert arguments to absolute value as unsigned type before calling __detail::__gcd or __detail::__lcm. * include/experimental/numeric (gcd, lcm): Likewise. * testsuite/26_numerics/gcd/gcd_neg.cc: Adjust expected errors. * testsuite/26_numerics/lcm/lcm_neg.cc: Likewise. * testsuite/26_numerics/gcd/92978.cc: New test. * testsuite/26_numerics/lcm/92978.cc: New test. * testsuite/experimental/numeric/92978.cc: New test. (cherry picked from commit 82db1a42e9254c9009bbf8ac01366da4d1ab6df5)
next prev parent reply other threads:[~2020-09-02 16:32 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-92978-4@http.gcc.gnu.org/bugzilla/> 2020-08-28 14:23 ` redi at gcc dot gnu.org 2020-08-28 22:11 ` cvs-commit at gcc dot gnu.org 2020-08-28 22:12 ` redi at gcc dot gnu.org 2020-09-02 16:23 ` cvs-commit at gcc dot gnu.org 2020-09-02 16:32 ` cvs-commit at gcc dot gnu.org [this message] 2020-09-21 23:14 ` cvs-commit at gcc dot gnu.org 2020-11-16 21:58 ` cvs-commit at gcc dot gnu.org 2020-11-16 21:59 ` redi at gcc dot gnu.org 2022-06-10 14:24 ` cvs-commit at gcc dot gnu.org 2022-08-03 13:46 ` cvs-commit at gcc dot gnu.org 2023-05-03 15:02 ` cvs-commit at gcc dot gnu.org 2023-05-03 16:34 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-92978-4-ZBPjFmoxmz@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).