[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92989

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Is the failure mode still the same?  mipsisa64-elf is primary, not sure if
mips-mti-linux-gnu is close enough to make this P1, still doing for now since
it's a build breaker.

[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92989

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
On #c6 it can't be reproduced with mipsisa64-elf gcc, asit has different size_t
etc. than the preprocessed source.
I can reproduce with cross to mips-mti-linux, with -quiet -nostdinc
locale-inst.ii -std=c++11 -mips16 -O2.
The ICE is in:

1643        for (i = FIRST_PSEUDO_REGISTER; i < max_regno; i++)
1644          if (lra_reg_info[i].nrefs != 0
1645              && reg_renumber[i] >= 0
1646              && overlaps_hard_reg_set_p
(lra_reg_info[i].conflict_hard_regs,
1647                                          PSEUDO_REGNO_MODE (i),
reg_renumber[i]))
1648            gcc_unreachable ();

Richard, could you please have a look again?

[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92989

--- Comment #10 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #9)
> Richard, could you please have a look again?

OK, I'll try to get to this early next week.

[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92989

rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92989

rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2020-April/5
                   |                            |43302.html

--- Comment #11 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Patch posted here:
https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543302.html

[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92989

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:e83714f65d1f75fc5af39f9fdc520a909dfc7635

commit r10-7570-ge83714f65d1f75fc5af39f9fdc520a909dfc7635
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Sat Apr 4 17:23:40 2020 +0100

    lra: Stop eh_return data regs being incorrectly marked live [PR92989]

    lra_assign has an assert to make sure that no pseudo is allocated
    to a conflicting hard register.  It used to be restricted to
    !flag_ipa_ra, but in g:a1e6ee38e708ef2bdef4 I'd enabled it for
    flag_ipa_ra too.  It then tripped a few times while building
    libstdc++ for mips-mti-linux.

    Previous patches fixed one of the problems: registers clobbered
    by the taking of an exception were being treated as live at the
    beginning of the EH receiver, and this got propagated to predecessor
    blocks.  But it turns out that there was a second problem: eh_return
    data registers were also being marked live in the same way.

    These registers are defined by the unwinder and so in reality they
    are live on entry to the EH receiver.  But definitions can only happen
    in blocks, not on edges, so for liveness purposes we use artificial
    definitions at the start of the EH receiver.  process_bb_lives should
    therefore model the effect of a definition, not a plain use.

    2020-04-06  Richard Sandiford  <richard.sandiford@arm.com>

    gcc/
            PR rtl-optimization/92989
            * lra-lives.c (process_bb_lives): Do not treat eh_return data
            registers as being live at the beginning of the EH receiver.

[Bug rtl-optimization/92989] [10 Regression] The mips-mti-linux-gnu fails to build after r276327

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92989

rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
I think it really has been fixed this time.  I was able to build a
mips-mti-linux-gnu toolchain to completion (with libsanitizer disabled).

Sorry for the runaround.