[Bug target/93082] macOS Authorization.h needs fixinclude

[Bug target/93082] macOS Authorization.h needs fixinclude

[grobian at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

Fabian Groffen <grobian at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |grobian at gentoo dot org

--- Comment #3 from Fabian Groffen <grobian at gentoo dot org> ---
The problem with this snippet is that it doesn't work on Frameworks, does it? 
At least for me, it seems it searches from usr/include only?

[Bug target/93082] macOS Authorization.h needs fixinclude

[mcccs at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #4 from mcccs at gmx dot com ---
(In reply to Fabian Groffen from comment #3)
> The problem with this snippet is that it doesn't work on Frameworks, does
> it?  At least for me, it seems it searches from usr/include only?

I'm not sure but it sounds likely. Isn't usr/include the higher-priority
#include <...> search directory?

[Bug target/93082] macOS Authorization.h needs fixinclude

[sam at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #5 from Sam James <sam at gentoo dot org> ---
I've also reported this to Apple as FB8919799 (and on openradar - why not?
https://openradar.appspot.com/radar?id=4952611266494464).

[Bug target/93082] macOS Authorization.h needs fixinclude

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=90835,
                   |                            |https://bugs.llvm.org/show_
                   |                            |bug.cgi?id=44406
                 CC|                            |bkorb at gnu dot org,
                   |                            |iains at gcc dot gnu.org,
                   |                            |mikestump at comcast dot net

--- Comment #6 from Eric Gallager <egallager at gcc dot gnu.org> ---
This is hitting me in my fork of Apple's version of gdb; cc-ing Darwin and
fixincludes maintainers

[Bug target/93082] macOS Authorization.h needs fixinclude

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #7 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Fabian Groffen from comment #3)
> The problem with this snippet is that it doesn't work on Frameworks, does
> it?  At least for me, it seems it searches from usr/include only?

Yeah I'm pretty sure fixincludes doesn't work with Frameworks; is that worth
opening a separate bug for, or should it just be tracked as part of this one?

[Bug target/93082] macOS Authorization.h needs fixinclude

[bkorb at gnu dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #8 from Bruce Korb <bkorb at gnu dot org> ---
It should not be terribly difficult to add another include tree for fixinc to
search. Also, unless 32 is cast as forever being the only value
kAuthorizationExternalFormLength could possibly ever have:

    select    =
    "static const size_t kAuthorizationExternalFormLength = (32);\n";
    c_fix     = format;
    c_fix_arg =
    "enum { kAuthorizationExternalFormLength = %1 };\n";

BTW:
1. if you're going to simply replace text

2. on page https://gcc.gnu.org/wiki/GitMirror the "getting started" section
leads to this error:

> fatal: 'svn/trunk' is not a commit and a branch 'trunk' cannot be created from it

(I don't have access to the GCC tree anymore [lost keys], so I'm starting
over.)

[Bug target/93082] macOS Authorization.h needs fixinclude

[bkorb at gnu dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #9 from Bruce Korb <bkorb at gnu dot org> ---
Um, I didn't finish my misthink for item#1 above. Please ignore. :)

[Bug target/93082] macOS Authorization.h needs fixinclude

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #10 from Iain Sandoe <iains at gcc dot gnu.org> ---
I also have a few "clang compatibility workarounds" for GCC (including one for
this specific case) - but they need putting behind some "-fclang-compatibility"
flag or so.

Hopefully, will work on integrating them in GCC-13.

In some cases that is going to work better than a fix includes.

FWIW this is not actually a bug in GCC, the bug is in the headers as Andrew
points out (the value is valid in C++ but not for C):

" Funny how clang thinks this was an GNU extension when it is not one."

I do not currently have a plan to try and build a second fix includes tree for
Frameworks, but happy to review patches if someone else does :)

[Bug target/93082] macOS Authorization.h needs fixinclude

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #11 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 52980
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52980&action=edit
work in progress patch for this case

 * this is not finished (needs to be conditional on a compatibility flag)
 * might not be acceptable upstream (depending on whether other maintainers are
willing to accept clang extension work-arounds). 

However, AFAICS this 'extension' would affect all targets if they were
presented with such input (so that this is not actually a Darwin-specific
problem) - it's just that we see it in the headers.

The patch is against recent master, but I'd expect it to apply reasonably
easily to 12.1, 11.3 and 10.x.

[Bug target/93082] macOS Authorization.h needs fixinclude

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #12 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #10)
> I do not currently have a plan to try and build a second fix includes tree
> for Frameworks, but happy to review patches if someone else does :)

OK I'll open a separate bug for that and self-assign

[Bug target/93082] macOS Authorization.h needs fixinclude

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #13 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Eric Gallager from comment #12)
> OK I'll open a separate bug for that and self-assign

(that's bug 105719 now, for reference)

[Bug target/93082] macOS Authorization.h needs fixinclude

[sam at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #14 from Sam James <sam at gentoo dot org> ---
This seems to be fixed in the latest macOS SDK (13.1 at least). But obviously
that doesn't help folks who need to use older SDKs.