public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/93116] match.pd uses convert/tree_nop_conversion_p instead of nop_convert
Date: Sat, 22 Jul 2023 06:35:13 +0000	[thread overview]
Message-ID: <bug-93116-4-UUoJKHUKpV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93116-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93116

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So the biggest issue here is that if we use nop_convert here, we will need to
check for vectors and use view_convert instead of convert in the resulting
output for the patterns.

like what is done for:
/* Fold -((int)x >> (prec - 1)) into (unsigned)x >> (prec - 1).  */

So each pattern would need to be audited while being changed. And testcases be
added too ...

           reply	other threads:[~2023-07-22  6:35 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <bug-93116-4@http.gcc.gnu.org/bugzilla/>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93116-4-UUoJKHUKpV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).