* [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups
[not found] <bug-93195-4@http.gcc.gnu.org/bugzilla/>
@ 2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-07-23 6:51 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-05-07 11:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93195
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.0 |10.2
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.1 has been released.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups
[not found] <bug-93195-4@http.gcc.gnu.org/bugzilla/>
2020-05-07 11:56 ` [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups jakub at gcc dot gnu.org
@ 2020-07-23 6:51 ` rguenth at gcc dot gnu.org
2020-12-02 13:38 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-07-23 6:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93195
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.2 |10.3
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10.2 is released, adjusting target milestone.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups
[not found] <bug-93195-4@http.gcc.gnu.org/bugzilla/>
2020-05-07 11:56 ` [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups jakub at gcc dot gnu.org
2020-07-23 6:51 ` rguenth at gcc dot gnu.org
@ 2020-12-02 13:38 ` cvs-commit at gcc dot gnu.org
2020-12-02 13:39 ` hjl.tools at gmail dot com
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-12-02 13:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93195
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:
https://gcc.gnu.org/g:694d4a6d0c466d0fbc97920a9c6641a7b349ca35
commit r11-5656-g694d4a6d0c466d0fbc97920a9c6641a7b349ca35
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Wed Dec 2 05:32:37 2020 -0800
Use the section flag 'o' for __patchable_function_entries
This commit in GNU binutils 2.35:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=b7d072167715829eed0622616f6ae0182900de3e
added the section flag 'o' to .section directive:
.section __patchable_function_entries,"awo",@progbits,foo
which specifies the symbol name which the section references. Assembler
creates a unique __patchable_function_entries section with the section,
where foo is defined, as its linked-to section. Linker keeps a section
if its linked-to section is kept during garbage collection.
This patch checks assembler support for the section flag 'o' and uses
it to implement __patchable_function_entries section. Since Solaris may
use GNU assembler with Solairs ld. Even if GNU assembler supports the
section flag 'o', it doesn't mean that Solairs ld supports it. This
feature is disabled for Solairs targets.
gcc/
PR middle-end/93195
PR middle-end/93197
* configure.ac (HAVE_GAS_SECTION_LINK_ORDER): New. Define 1 if
the assembler supports the section flag 'o' for specifying
section with link-order.
* output.h (SECTION_LINK_ORDER): New. Defined to 0x8000000.
(SECTION_MACH_DEP): Changed from 0x8000000 to 0x10000000.
* targhooks.c (default_print_patchable_function_entry): Pass
SECTION_LINK_ORDER to switch_to_section if the section flag 'o'
works. Pass current_function_decl to switch_to_section.
* varasm.c (default_elf_asm_named_section): Use 'o' flag for
SECTION_LINK_ORDER if assembler supports it.
* config.in: Regenerated.
* configure: Likewise.
* doc/sourcebuild.texi: Document o_flag_in_section.
gcc/testsuite/
PR middle-end/93195
* g++.dg/pr93195a.C: New test.
* g++.dg/pr93195b.C: Likewise.
* lib/target-supports.exp
(check_effective_target_o_flag_in_section): New proc.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups
[not found] <bug-93195-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-12-02 13:38 ` cvs-commit at gcc dot gnu.org
@ 2020-12-02 13:39 ` hjl.tools at gmail dot com
2020-12-15 21:01 ` jakub at gcc dot gnu.org
2020-12-17 3:59 ` i at maskray dot me
5 siblings, 0 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2020-12-02 13:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93195
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|10.3 |11.0
--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 11.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups
[not found] <bug-93195-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-12-02 13:39 ` hjl.tools at gmail dot com
@ 2020-12-15 21:01 ` jakub at gcc dot gnu.org
2020-12-17 3:59 ` i at maskray dot me
5 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-15 21:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93195
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I believe this broke building the kernel, see
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561974.html
for details.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug middle-end/93195] -fpatchable-function-entries : __patchable_function_entries should consider comdat groups
[not found] <bug-93195-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2020-12-15 21:01 ` jakub at gcc dot gnu.org
@ 2020-12-17 3:59 ` i at maskray dot me
5 siblings, 0 replies; 6+ messages in thread
From: i at maskray dot me @ 2020-12-17 3:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93195
--- Comment #10 from Fangrui Song <i at maskray dot me> ---
(In reply to Jakub Jelinek from comment #9)
> I believe this broke building the kernel, see
> https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561974.html
> for details.
For
> ld: .init.data has both ordered [`__patchable_function_entries' in init/main.o] and unordered [`.init.data' in ./drivers/firmware/efi/libstub/vsprintf.stub.o] sections
ld should be flexible in mixed SHF_LINK_ORDER & non-SHF_LINK_ORDER components
in an output section
https://sourceware.org/bugzilla/show_bug.cgi?id=26256
^ permalink raw reply [flat|nested] 6+ messages in thread