[Bug ipa/93347] [10 Regression] ICE: verify_cgraph_node failed (error: calls_comdat_local is set outside of a comdat group)

[Bug ipa/93347] [10 Regression] ICE: verify_cgraph_node failed (error: calls_comdat_local is set outside of a comdat group)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93347

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:72b3bc895f023bf451357659cfe96c966945bdf9

commit r10-7306-g72b3bc895f023bf451357659cfe96c966945bdf9
Author: Jan Hubicka <jh@suse.cz>
Date:   Fri Mar 20 22:06:24 2020 +0100

    Fix verifier ICE on wrong comdat local flag [PR93347]

    gcc/ChangeLog:

    2020-03-20  Jan Hubicka  <hubicka@ucw.cz>

            PR ipa/93347
            * cgraph.c (symbol_table::create_edge): Update calls_comdat_local
flag.
            (cgraph_edge::redirect_callee): Move here; likewise.
            (cgraph_node::remove_callees): Update calls_comdat_local flag.
            (cgraph_node::verify_node): Verify that calls_comdat_local flag
match
            reality.
            (cgraph_node::check_calls_comdat_local_p): New member function.
            * cgraph.h (cgraph_node::check_calls_comdat_local_p): Declare.
            (cgraph_edge::redirect_callee): Move offline.
            * ipa-fnsummary.c (compute_fn_summary): Do not compute
            calls_comdat_local flag here.
            * ipa-inline-transform.c (inline_call): Fix updating of
            calls_comdat_local flag.
            * ipa-split.c (split_function): Use true instead of 1 to set the
flag.
            * symtab.c (symtab_node::add_to_same_comdat_group): Update
            calls_comdat_local flag.

    gcc/testsuite/ChangeLog:

    2020-03-20  Jan Hubicka  <hubicka@ucw.cz>

            * g++.dg/torture/pr93347.C: New test.

[Bug ipa/93347] [10 Regression] ICE: verify_cgraph_node failed (error: calls_comdat_local is set outside of a comdat group)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93347

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed. I noticed that some of the tests are not devirtualized, so we may move
that into new PR.