public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/93355] Missing diagnostic for missing fclose in intl/localealias.c
Date: Thu, 04 Mar 2021 00:27:52 +0000	[thread overview]
Message-ID: <bug-93355-4-hzzgONtWnR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93355-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93355

--- Comment #8 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
(In reply to David Malcolm from comment #4)
> (a) It happens to successfully explore enough of the graph to find the leak,
> but hits complexity limits at 1 program point:
> 
> pr93355-localealias.c:263:41: warning: terminating analysis for this program
> point: callstring: [(SN: 66 -> SN: 85 in _nl_expand_alias)] before (SN: 21
> stmt: 0):  _7 = *cp_107;EN: 163, EN: 170, EN: 177, EN: 370, EN: 557, EN:
> 794, EN: 801, EN: 808 [-Wanalyzer-too-complex]
>   263 |       while (isspace ((unsigned char) cp[0]))
>       |                                       ~~^~~

If I get rid of _nl_expand_alias then the state explosion goes away.
There are 2 enodes at the callsite to read_alias_file, so the entrypoint starts
with 3 enodes (both calls, plus independent analysis)
Hence there's already a 3x for that function.
Without that 3x, things seem reasonable within read_alias_file.
So (a) may be really "just" a call summarization problem.

  parent reply	other threads:[~2021-03-04  0:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93355-4@http.gcc.gnu.org/bugzilla/>
2020-09-21 22:49 ` cvs-commit at gcc dot gnu.org
2020-09-24  1:26 ` cvs-commit at gcc dot gnu.org
2021-01-26 21:33 ` dmalcolm at gcc dot gnu.org
2021-02-02  2:53 ` cvs-commit at gcc dot gnu.org
2021-02-02  2:55 ` cvs-commit at gcc dot gnu.org
2021-02-02 14:38 ` dmalcolm at gcc dot gnu.org
2021-03-04  0:27 ` dmalcolm at gcc dot gnu.org [this message]
2021-03-05 23:54 ` dmalcolm at gcc dot gnu.org
2021-03-11 22:48 ` cvs-commit at gcc dot gnu.org
2021-03-11 23:18 ` dmalcolm at gcc dot gnu.org
2021-03-12 20:10 ` [Bug analyzer/93355] Analyzer -Wanalysis-too-complex on intl/localealias.c due to poor call summarization dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93355-4-hzzgONtWnR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).