From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B18F9385C426; Fri, 17 Apr 2020 12:06:43 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B18F9385C426
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1587125203;
 bh=F2RY7B7WetzBLojO9CGF8HTih6zD6/9pQfi8OexshV0=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=V29LsDUumIMS2gDtAmZT7UA5BJoKtEQoka/wy95XxI/d7kiajEJ9EPOE763pwDIm9
 tTGG8MczM8YdFOygp4yortO8k2OvqNQH/l46qRIS5OIxnAGgIbG5HGULV9oNfw/pAE
 GXoAMFPnVaHFh5L9yXzMGstiyuyNjOPAh5/yYBVs=
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/93385] [10 Regression] wrong code with u128 modulo at -O2
 -fno-dce -fno-ipa-cp -fno-tree-dce
Date: Fri, 17 Apr 2020 12:06:43 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: diagnostic, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jamborm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-93385-4-z0s3gyisE8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-93385-4@http.gcc.gnu.org/bugzilla/>
References: <bug-93385-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2020 12:06:43 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D93385

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Comment on attachment 48302
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D48302
Untested fix

+           /* IPA-SRA does not analyze other types of statements.  */
+           gcc_unreachable ();
Won't this ICE on any is_gimple_debug stmt?  Those should be just ignored a=
nd
normal SSA_NAME handling should DTRT for those.
As for PHIs, can you just gsi_remove them?

Plus, I think in isra_track_scalar_value_uses for non-is_gimple_{debug,call=
} we
should punt if !flag_tree_dce, i.e. when user asked not to perform dead code
elimination.  Though, guess that hunk should be added only after this is te=
sted
(and perhaps the testcase or its copy should use -fdisable-tree-dce or what=
ever
other way to avoid doing DCE even when flag_tree_dce is non-zero.=