public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/93413] Defaulted constexpr Destructor not being found during constant evaluation
Date: Thu, 03 Nov 2022 18:56:33 +0000	[thread overview]
Message-ID: <bug-93413-4-nsU8EvOLss@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93413-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93413

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:c0b38e9fec71dc4cc5e99b1f0cb159c15a8da9ba

commit r13-3638-gc0b38e9fec71dc4cc5e99b1f0cb159c15a8da9ba
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Nov 3 14:55:35 2022 -0400

    c++: constexpr error with defaulted virtual dtor [PR93413]

    We're rejecting the below testcase with

      error: 'virtual constexpr Base::~Base()' used before its definition
      error: 'virtual constexpr Derived::~Derived()' used before its definition

    due to special handling in mark_used added by r181272 to defer synthesis
    of virtual destructors until EOF (where we can set their linkage), which
    in turn makes them effectively unusable during constexpr evaluation.

    Fortunately it seems this special handling is unnecessary ever since
    r208030 enabled us to tentatively set linkage of all defaulted virtual
    destructors, including templated ones.  So this patch gets rid of this
    special handling.

            PR c++/93413

    gcc/cp/ChangeLog:

            * decl2.cc (mark_used): Don't defer synthesis of virtual
            functions.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/constexpr-virtual21.C: New test.

  parent reply	other threads:[~2022-11-03 18:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93413-4@http.gcc.gnu.org/bugzilla/>
2021-04-24  2:39 ` [Bug c++/93413] Destructor definition not " ldalessandro at gmail dot com
2021-08-17  5:56 ` pinskia at gcc dot gnu.org
2021-08-17  5:57 ` pinskia at gcc dot gnu.org
2021-08-17  5:58 ` pinskia at gcc dot gnu.org
2022-02-23  7:46 ` pinskia at gcc dot gnu.org
2022-07-13 22:44 ` pinskia at gcc dot gnu.org
2022-07-13 22:45 ` pinskia at gcc dot gnu.org
2022-11-02 20:39 ` pinskia at gcc dot gnu.org
2022-11-02 23:58 ` [Bug c++/93413] Defaulted constexpr Destructor not being " ppalka at gcc dot gnu.org
2022-11-03 18:56 ` cvs-commit at gcc dot gnu.org [this message]
2022-11-03 19:11 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93413-4-nsU8EvOLss@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).