public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/93435] [8/9/10 Regression] Hang with -O2 on innocuous looking code with GCC 8.3 Date: Fri, 20 Mar 2020 23:21:35 +0000 [thread overview] Message-ID: <bug-93435-4-mxjD6nipg8@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-93435-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93435 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>: https://gcc.gnu.org/g:29f23ed79b60949fc60f6fdbbd931bd58090b241 commit r10-7309-g29f23ed79b60949fc60f6fdbbd931bd58090b241 Author: Martin Jambor <mjambor@suse.cz> Date: Sat Mar 21 00:21:02 2020 +0100 sra: Cap number of sub-access propagations with a param (PR 93435) PR 93435 is a perfect SRA bomb. It initializes an array of 16 chars element-wise, then uses that to initialize an aggregate that consists of four such arrays, that one to initialize one four times as big as the previous one all the way to an aggregate that has 64kb. This causes the sub-access propagation across assignments to create thousands of byte-sized artificial accesses which are then eligible to be replaced - they do facilitate forward propagation but there is enough of them for DSE to never finish. This patch avoids that situation by accounting how many of such replacements can be created per SRA candidate. The default value of 32 was just the largest power of two that did not slow down compilation of the testcase, but it should also hopefully be big enough for any reasonable input that might rely on the optimization. 2020-03-20 Martin Jambor <mjambor@suse.cz> PR tree-optimization/93435 * params.opt (sra-max-propagations): New parameter. * tree-sra.c (propagation_budget): New variable. (budget_for_propagation_access): New function. (propagate_subaccesses_from_rhs): Use it. (propagate_subaccesses_from_lhs): Likewise. (propagate_all_subaccesses): Set up and destroy propagation_budget. gcc/testsuite/ * gcc.dg/tree-ssa/pr93435.c: New test.
next prev parent reply other threads:[~2020-03-20 23:21 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-93435-4@http.gcc.gnu.org/bugzilla/> 2020-03-17 13:26 ` jakub at gcc dot gnu.org 2020-03-19 13:31 ` jamborm at gcc dot gnu.org 2020-03-20 23:21 ` cvs-commit at gcc dot gnu.org [this message] 2020-03-20 23:24 ` [Bug tree-optimization/93435] [8/9 " jamborm at gcc dot gnu.org 2020-04-03 18:33 ` cvs-commit at gcc dot gnu.org 2020-04-03 20:01 ` cvs-commit at gcc dot gnu.org 2020-04-03 20:09 ` jamborm at gcc dot gnu.org 2021-04-30 7:58 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-93435-4-mxjD6nipg8@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).