public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/93492] Broken code with -fpatchable-function-entry and -fcf-protection=full
Date: Fri, 10 Jul 2020 14:33:45 +0000	[thread overview]
Message-ID: <bug-93492-4-JnQ2Hx1n19@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93492-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93492

--- Comment #31 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #30)
> > --- Comment #29 from H.J. Lu <hjl.tools at gmail dot com> ---
> > (In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #28)
> >> > --- Comment #27 from H.J. Lu <hjl.tools at gmail dot com> ---
> >> > (In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #26)
> >> >> > --- Comment #25 from H.J. Lu <hjl.tools at gmail dot com> ---
> >> >> > -fpatchable-function-entry and -mfentry generate special instruction
> >> >> > sequence at function entry.  Does Solaris support such special
> >> >> > instruction sequence?
> >> >> 
> >> >> Where would such support live?  The kernel?  libc.so.1?  ld.so.1?
> >> >
> >> > -fpatchable-function-entry and -mfentry are used in Linux kernel.
> >> 
> >> In that case: no.  The Solaris kernel can (and is) compiled both by gcc
> >> and Studio cc, and the latter certainly hasn't anything similar.
> >
> > Then just skip these tests on Solaris.
> 
> If this is a Linux-only feature, shouldn't the tests rather be
> restricted to Linux instead?  It certainly also fails on freebsd,
> darwin, mingw and whatever more.  Having to skip it on all those
> explicitly (until we discover the next target we forgot about) seems
> just the wrong way round.


These features aren't Linux specific.  But they do require special
sequence at function entrance.  Solaris has a different function entry
which may not work with these features.

  parent reply	other threads:[~2020-07-10 14:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93492-4@http.gcc.gnu.org/bugzilla/>
2020-05-02  4:07 ` cvs-commit at gcc dot gnu.org
2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-06-12  3:45 ` cvs-commit at gcc dot gnu.org
2020-06-12  3:49 ` hjl.tools at gmail dot com
2020-06-14 15:38 ` ro at gcc dot gnu.org
2020-06-14 15:47 ` hjl.tools at gmail dot com
2020-06-14 16:52 ` iains at gcc dot gnu.org
2020-06-15 13:12 ` hjl.tools at gmail dot com
2020-06-26 23:13 ` hjl.tools at gmail dot com
2020-07-10 12:57 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-07-10 13:56 ` hjl.tools at gmail dot com
2020-07-10 14:03 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-07-10 14:04 ` hjl.tools at gmail dot com
2020-07-10 14:06 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-07-10 14:12 ` hjl.tools at gmail dot com
2020-07-10 14:16 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-07-10 14:33 ` hjl.tools at gmail dot com [this message]
2020-07-10 14:41 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-07-10 15:53 ` mikestump at comcast dot net
2020-07-10 21:54 ` hjl.tools at gmail dot com
2020-07-12 12:06 ` cvs-commit at gcc dot gnu.org
2020-07-12 12:07 ` hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93492-4-JnQ2Hx1n19@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).