* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
@ 2020-07-11 20:46 ` dominiq at lps dot ens.fr
2020-07-19 20:50 ` dominiq at lps dot ens.fr
` (14 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-11 20:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2020-07-11
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Confirmed since at least GCC7.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
2020-07-11 20:46 ` [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor dominiq at lps dot ens.fr
@ 2020-07-19 20:50 ` dominiq at lps dot ens.fr
2020-07-19 21:59 ` dominiq at lps dot ens.fr
` (13 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-19 20:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
--- ../_clean/libgfortran/io/write_float.def 2020-06-13 03:11:55.000000000
+0200
+++ libgfortran/io/write_float.def 2020-07-19 22:46:57.000000000 +0200
@@ -399,7 +399,7 @@ build_float_string (st_parameter_dt *dtp
updown:
rchar = '0';
- if (ft != FMT_F && w > 0 && d == 0 && p == 0)
+ if (ft != FMT_F && ft !=FMT_EN && w > 0 && d == 0 && p == 0)
nbefore = 1;
/* Scan for trailing zeros to see if we really need to round it. */
for(i = nbefore + nafter; i < ndigits; i++)
should do the trick. I am currently try to reuse gfortran.dg/fmt_en.f90 for a
more general testing.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
2020-07-11 20:46 ` [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor dominiq at lps dot ens.fr
2020-07-19 20:50 ` dominiq at lps dot ens.fr
@ 2020-07-19 21:59 ` dominiq at lps dot ens.fr
2020-07-19 22:01 ` dominiq at lps dot ens.fr
` (12 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-19 21:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Created attachment 48894
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48894&action=edit
Extensive test with RU and EN
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-07-19 21:59 ` dominiq at lps dot ens.fr
@ 2020-07-19 22:01 ` dominiq at lps dot ens.fr
2020-07-20 10:00 ` dominiq at lps dot ens.fr
` (11 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-19 22:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Created attachment 48895
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48895&action=edit
Extensive test with RD and EN
It would be nice to check that I did not make any mistake.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-07-19 22:01 ` dominiq at lps dot ens.fr
@ 2020-07-20 10:00 ` dominiq at lps dot ens.fr
2020-07-21 15:23 ` dominiq at lps dot ens.fr
` (10 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-20 10:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jvdelisle2 at outlook dot com
Target Milestone|--- |8.5
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2020-07-20 10:00 ` dominiq at lps dot ens.fr
@ 2020-07-21 15:23 ` dominiq at lps dot ens.fr
2020-07-21 15:24 ` dominiq at lps dot ens.fr
` (9 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-21 15:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Created attachment 48909
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48909&action=edit
Extensive test with RZ and EN
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2020-07-21 15:23 ` dominiq at lps dot ens.fr
@ 2020-07-21 15:24 ` dominiq at lps dot ens.fr
2020-07-21 15:28 ` dominiq at lps dot ens.fr
` (8 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-21 15:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Created attachment 48910
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48910&action=edit
Extensive test with RN and EN
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2020-07-21 15:24 ` dominiq at lps dot ens.fr
@ 2020-07-21 15:28 ` dominiq at lps dot ens.fr
2020-07-21 19:25 ` anlauf at gcc dot gnu.org
` (7 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-21 15:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Could someone used to git commit the fix and the tests and back port them to
all the active branches?
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2020-07-21 15:28 ` dominiq at lps dot ens.fr
@ 2020-07-21 19:25 ` anlauf at gcc dot gnu.org
2020-07-21 22:15 ` dominiq at lps dot ens.fr
` (6 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: anlauf at gcc dot gnu.org @ 2020-07-21 19:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #8 from anlauf at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #7)
> Could someone used to git commit the fix and the tests and back port them to
> all the active branches?
I think the normal procedure would be to submit this for review first.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2020-07-21 19:25 ` anlauf at gcc dot gnu.org
@ 2020-07-21 22:15 ` dominiq at lps dot ens.fr
2020-07-23 21:24 ` dominiq at lps dot ens.fr
` (5 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-21 22:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #9 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Patch submitted at https://gcc.gnu.org/pipermail/fortran/2020-July/054769.html.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2020-07-21 22:15 ` dominiq at lps dot ens.fr
@ 2020-07-23 21:24 ` dominiq at lps dot ens.fr
2020-07-24 18:48 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-23 21:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #10 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The patch applies and regtest cleanly down to GCC8.
IMO this is nasty wrong code and it should be fixed on all the active branches.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2020-07-23 21:24 ` dominiq at lps dot ens.fr
@ 2020-07-24 18:48 ` cvs-commit at gcc dot gnu.org
2020-07-25 10:55 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-07-24 18:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Kथà¤nig <tkoenig@gcc.gnu.org>:
https://gcc.gnu.org/g:05e0971bcf94a481cbfa2731484f024a67dbd4a5
commit r11-2309-g05e0971bcf94a481cbfa2731484f024a67dbd4a5
Author: Dominique d'Humieres <dhumieres.dominique@free.fr>
Date: Fri Jul 24 20:07:12 2020 +0200
PR 93592 - Invalid UP/DOWN rounding with EN descriptor.
The fix is obvious (I have added a comment). The tests are probably
an overkill, but it does not hurt.
libgfortran/ChangeLog:
PR fortran/93592
* io/write_float.def (build_float_string): Do not reset
nbefore for FMT_F and FMT_EN.
gcc/testsuite/ChangeLog:
PR fortran/93592
* gfortran.dg/fmt_en.f90: Adjust test.
* gfortran.dg/fmt_en_rd.f90: New test.
* gfortran.dg/fmt_en_rn.f90: New test.
* gfortran.dg/fmt_en_ru.f90: New test.
* gfortran.dg/fmt_en_rz.f90: New test.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2020-07-24 18:48 ` cvs-commit at gcc dot gnu.org
@ 2020-07-25 10:55 ` cvs-commit at gcc dot gnu.org
2020-07-25 10:58 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-07-25 10:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Thomas Kथà¤nig
<tkoenig@gcc.gnu.org>:
https://gcc.gnu.org/g:b45f51d467c6c192c70f57e517bec3a3c0c9d1f4
commit r10-8531-gb45f51d467c6c192c70f57e517bec3a3c0c9d1f4
Author: Dominique d'Humieres <dhumieres.dominique@free.fr>
Date: Fri Jul 24 20:07:12 2020 +0200
PR 93592 - Invalid UP/DOWN rounding with EN descriptor.
The fix is obvious (I have added a comment). The tests are probably
an overkill, but it does not hurt.
libgfortran/ChangeLog:
PR fortran/93592
* io/write_float.def (build_float_string): Do not reset
nbefore for FMT_F and FMT_EN.
gcc/testsuite/ChangeLog:
PR fortran/93592
* gfortran.dg/fmt_en.f90: Adjust test.
* gfortran.dg/fmt_en_rd.f90: New test.
* gfortran.dg/fmt_en_rn.f90: New test.
* gfortran.dg/fmt_en_ru.f90: New test.
* gfortran.dg/fmt_en_rz.f90: New test.
(cherry picked from commit 05e0971bcf94a481cbfa2731484f024a67dbd4a5)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2020-07-25 10:55 ` cvs-commit at gcc dot gnu.org
@ 2020-07-25 10:58 ` cvs-commit at gcc dot gnu.org
2020-07-25 11:45 ` cvs-commit at gcc dot gnu.org
2020-07-25 15:26 ` dominiq at lps dot ens.fr
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-07-25 10:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Thomas Kथà¤nig
<tkoenig@gcc.gnu.org>:
https://gcc.gnu.org/g:eca316afa46907e6b0e1513ecbc3010aaf2590f3
commit r9-8765-geca316afa46907e6b0e1513ecbc3010aaf2590f3
Author: Dominique d'Humieres <dhumieres.dominique@free.fr>
Date: Fri Jul 24 20:07:12 2020 +0200
PR 93592 - Invalid UP/DOWN rounding with EN descriptor.
The fix is obvious (I have added a comment). The tests are probably
an overkill, but it does not hurt.
libgfortran/ChangeLog:
PR fortran/93592
* io/write_float.def (build_float_string): Do not reset
nbefore for FMT_F and FMT_EN.
gcc/testsuite/ChangeLog:
PR fortran/93592
* gfortran.dg/fmt_en.f90: Adjust test.
* gfortran.dg/fmt_en_rd.f90: New test.
* gfortran.dg/fmt_en_rn.f90: New test.
* gfortran.dg/fmt_en_ru.f90: New test.
* gfortran.dg/fmt_en_rz.f90: New test.
(cherry picked from commit 05e0971bcf94a481cbfa2731484f024a67dbd4a5)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2020-07-25 10:58 ` cvs-commit at gcc dot gnu.org
@ 2020-07-25 11:45 ` cvs-commit at gcc dot gnu.org
2020-07-25 15:26 ` dominiq at lps dot ens.fr
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-07-25 11:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Thomas Kथà¤nig
<tkoenig@gcc.gnu.org>:
https://gcc.gnu.org/g:1757a63809d6c6073c87978c22dcfffe85753c0f
commit r8-10375-g1757a63809d6c6073c87978c22dcfffe85753c0f
Author: Dominique d'Humieres <dhumieres.dominique@free.fr>
Date: Fri Jul 24 20:07:12 2020 +0200
PR 93592 - Invalid UP/DOWN rounding with EN descriptor.
The fix is obvious (I have added a comment). The tests are probably
an overkill, but it does not hurt.
libgfortran/ChangeLog:
PR fortran/93592
* io/write_float.def (build_float_string): Do not reset
nbefore for FMT_F and FMT_EN.
gcc/testsuite/ChangeLog:
PR fortran/93592
* gfortran.dg/fmt_en.f90: Adjust test.
* gfortran.dg/fmt_en_rd.f90: New test.
* gfortran.dg/fmt_en_rn.f90: New test.
* gfortran.dg/fmt_en_ru.f90: New test.
* gfortran.dg/fmt_en_rz.f90: New test.
(cherry picked from commit 05e0971bcf94a481cbfa2731484f024a67dbd4a5)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libfortran/93592] Invalid UP/DOWN rounding with EN descriptor
[not found] <bug-93592-4@http.gcc.gnu.org/bugzilla/>
` (14 preceding siblings ...)
2020-07-25 11:45 ` cvs-commit at gcc dot gnu.org
@ 2020-07-25 15:26 ` dominiq at lps dot ens.fr
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-07-25 15:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93592
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #15 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Patch committed to all the active branches. Closing.
Tanks for the report.
^ permalink raw reply [flat|nested] 16+ messages in thread