public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug gcov-profile/93623] No need to dump gcdas when forking
[not found] <bug-93623-4@http.gcc.gnu.org/bugzilla/>
@ 2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-05 14:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93623
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:d39f7dc8d558ca31a661b02d08ff090ce65e6652
commit r11-83-gd39f7dc8d558ca31a661b02d08ff090ce65e6652
Author: Martin Liska <mliska@suse.cz>
Date: Tue May 5 16:15:45 2020 +0200
Do locking for __gcov_dump and __gcov_reset as well.
PR gcov-profile/93623
* Makefile.in: Add _gcov_lock_unlock to LIBGCOV_INTERFACE.
* libgcov-interface.c (ALIAS_void_fn): Remove.
(__gcov_lock): New.
(__gcov_unlock): New.
(__gcov_flush): Use __gcov_lock and __gcov_unlock.
(__gcov_reset): Likewise.
(__gcov_dump): Likewise.
* libgcov.h (__gcov_lock): New declaration.
(__gcov_unlock): Likewise.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug gcov-profile/93623] No need to dump gcdas when forking
[not found] <bug-93623-4@http.gcc.gnu.org/bugzilla/>
2020-05-05 14:16 ` [Bug gcov-profile/93623] No need to dump gcdas when forking cvs-commit at gcc dot gnu.org
@ 2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-05 14:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93623
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:c0532db47d092430f8e8f497b2dc53343527bb13
commit r11-84-gc0532db47d092430f8e8f497b2dc53343527bb13
Author: Martin Liska <mliska@suse.cz>
Date: Tue May 5 16:15:46 2020 +0200
Use __gcov_dump and __gcov_reset in execv and fork context.
PR gcov-profile/93623
* libgcov-interface.c (__gcov_fork): Do not flush
and reset only in child process.
(__gcov_execl): Dump counters only and reset them
only if exec* fails.
(__gcov_execlp): Likewise.
(__gcov_execle): Likewise.
(__gcov_execv): Likewise.
(__gcov_execvp): Likewise.
(__gcov_execve): Likewise.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug gcov-profile/93623] No need to dump gcdas when forking
[not found] <bug-93623-4@http.gcc.gnu.org/bugzilla/>
2020-05-05 14:16 ` [Bug gcov-profile/93623] No need to dump gcdas when forking cvs-commit at gcc dot gnu.org
2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
@ 2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:16 ` marxin at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-05 14:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93623
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:811b7636cb8c10f1a550a76242b5666c7ae36da2
commit r11-85-g811b7636cb8c10f1a550a76242b5666c7ae36da2
Author: Martin Liska <mliska@suse.cz>
Date: Tue May 5 16:15:47 2020 +0200
Remove __gcov_flush.
PR gcov-profile/93623
* tree-cfg.c (stmt_can_terminate_bb_p): Update comment to reflect
reality.
PR gcov-profile/93623
* Makefile.in: Remove __gcov_flush.
* gcov.h (__gcov_flush): Remove.
* libgcov-interface.c (__gcov_flush): Remove.
(init_mx): Use renamed mutex.
(__gcov_lock): Likewise.
(__gcov_unlock): Likewise.
(__gcov_fork): Likewise.
(__gcov_flush): Remove.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug gcov-profile/93623] No need to dump gcdas when forking
[not found] <bug-93623-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
@ 2020-05-05 14:16 ` marxin at gcc dot gnu.org
2020-06-03 13:15 ` cdenizet at mozilla dot com
2020-06-08 14:48 ` marxin at gcc dot gnu.org
5 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-05-05 14:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93623
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #10 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed on master.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug gcov-profile/93623] No need to dump gcdas when forking
[not found] <bug-93623-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-05-05 14:16 ` marxin at gcc dot gnu.org
@ 2020-06-03 13:15 ` cdenizet at mozilla dot com
2020-06-08 14:48 ` marxin at gcc dot gnu.org
5 siblings, 0 replies; 6+ messages in thread
From: cdenizet at mozilla dot com @ 2020-06-03 13:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93623
--- Comment #11 from calixte <cdenizet at mozilla dot com> ---
Why did you remove __gcov_flush ?
FYI, we use it in Firefox to dump counters on SIGUSR1:
https://searchfox.org/mozilla-central/source/tools/code-coverage/CodeCoverageHandler.cpp#49
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug gcov-profile/93623] No need to dump gcdas when forking
[not found] <bug-93623-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2020-06-03 13:15 ` cdenizet at mozilla dot com
@ 2020-06-08 14:48 ` marxin at gcc dot gnu.org
5 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-06-08 14:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93623
--- Comment #12 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to calixte from comment #11)
> Why did you remove __gcov_flush ?
It is not a supported __gcov_* library call:
https://gcc.gnu.org/onlinedocs/gcc/Gcov-and-Optimization.html
You should rather call __gcov_dump and __gcov_reset functions.
> FYI, we use it in Firefox to dump counters on SIGUSR1:
> https://searchfox.org/mozilla-central/source/tools/code-coverage/
> CodeCoverageHandler.cpp#49
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-08 14:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-93623-4@http.gcc.gnu.org/bugzilla/>
2020-05-05 14:16 ` [Bug gcov-profile/93623] No need to dump gcdas when forking cvs-commit at gcc dot gnu.org
2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:16 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:16 ` marxin at gcc dot gnu.org
2020-06-03 13:15 ` cdenizet at mozilla dot com
2020-06-08 14:48 ` marxin at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).