public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/93628] ranges::equal_to doesn't work for types convertible to function pointers
Date: Wed, 10 Mar 2021 15:28:28 +0000	[thread overview]
Message-ID: <bug-93628-4-7i9POurrSP@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93628-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93628

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:dddd011113b6ceede733d7ae33eca695c06b181b

commit r11-7603-gdddd011113b6ceede733d7ae33eca695c06b181b
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Mar 10 15:27:06 2021 +0000

    libstdc++: Implement LWG 3530 for concept-constrained comparisons

    The proposed resolution for this library issue simplifies the
    constraints for compare_three_way, ranges::equal_to, ranges::less etc.
    so that they do not work with types which are convertible to pointers
    but which fail to meet the usual syntactic requirements for the
    comparisons.

    This affects the example in PR libstdc++/93628 but doesn't fix the
    problem described in that report.

    libstdc++-v3/ChangeLog:

            * include/bits/ranges_cmp.h (__eq_builtin_ptr_cmp): Remove.
            (ranges::equal_to, ranges::not_equal_to): Do not constrain
            with __eq_builtin_ptr_cmp.
            (ranges::less, ranges::greater, ranges::less_equal)
            (ranges::greater_equal): Do not constrain with
            __less_builtin_ptr_cmp.
            * libsupc++/compare (compare_three_way): Do not constrain with
            __3way_builtin_ptr_cmp.
            * testsuite/18_support/comparisons/object/builtin-ptr-three-way.cc:
Moved to...
            * testsuite/18_support/comparisons/object/lwg3530.cc: ...here.
            * testsuite/20_util/function_objects/range.cmp/lwg3530.cc: New
test.

  parent reply	other threads:[~2021-03-10 15:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93628-4@http.gcc.gnu.org/bugzilla/>
2020-04-15 19:36 ` redi at gcc dot gnu.org
2021-03-09 11:17 ` redi at gcc dot gnu.org
2021-03-10 15:28 ` cvs-commit at gcc dot gnu.org [this message]
2021-03-29 20:03 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93628-4-7i9POurrSP@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).