public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/93709] [10 regression] fortran.dg/minlocval_4.f90 fails on power 9 after r10-4161
[not found] <bug-93709-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-11 12:05 ` marxin at gcc dot gnu.org
2020-03-11 15:38 ` wschmidt at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-11 12:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93709
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
commit r10-7114-g37e0df8a9be5a8232f4ccb73cdadb02121ba523f
Author: Jiufu Guo <guojiufu@linux.ibm.com>
Date: Tue Mar 10 13:51:57 2020 +0800
rs6000: Check -+0 and NaN for smax/smin generation
PR93709 mentioned regressions on maxlocval_4.f90 and minlocval_f.f90 which
relates to max of '-inf' and 'nan'. This regression occur on P9 because
P9 new instruction 'xsmaxcdp' is generated.
And for C code `a < b ? b : a` is also generated as `xsmaxcdp` under -O2
for P9. While this instruction behavior more like C/C++ semantic (a>b?a:b).
This generates prevents 'xsmaxcdp' to be generated for those cases.
'xsmincdp' also is handled in patch.
gcc/
2020-03-10 Jiufu Guo <guojiufu@linux.ibm.com>
PR target/93709
* gcc/config/rs6000/rs6000.c (rs6000_emit_p9_fp_minmax): Check
NAN and SIGNED_ZEROR for smax/smin.
gcc/testsuite
2020-03-10 Jiufu Guo <guojiufu@linux.ibm.com>
PR target/93709
* gcc.target/powerpc/p9-minmax-3.c: New test.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug target/93709] [10 regression] fortran.dg/minlocval_4.f90 fails on power 9 after r10-4161
[not found] <bug-93709-4@http.gcc.gnu.org/bugzilla/>
2020-03-11 12:05 ` [Bug target/93709] [10 regression] fortran.dg/minlocval_4.f90 fails on power 9 after r10-4161 marxin at gcc dot gnu.org
@ 2020-03-11 15:38 ` wschmidt at gcc dot gnu.org
2020-03-19 4:58 ` cvs-commit at gcc dot gnu.org
2020-03-19 13:32 ` guojiufu at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: wschmidt at gcc dot gnu.org @ 2020-03-11 15:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93709
Bill Schmidt <wschmidt at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-03-11
Ever confirmed|0 |1
--- Comment #7 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Confirmed, since fixed on trunk. Do we want any backports?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug target/93709] [10 regression] fortran.dg/minlocval_4.f90 fails on power 9 after r10-4161
[not found] <bug-93709-4@http.gcc.gnu.org/bugzilla/>
2020-03-11 12:05 ` [Bug target/93709] [10 regression] fortran.dg/minlocval_4.f90 fails on power 9 after r10-4161 marxin at gcc dot gnu.org
2020-03-11 15:38 ` wschmidt at gcc dot gnu.org
@ 2020-03-19 4:58 ` cvs-commit at gcc dot gnu.org
2020-03-19 13:32 ` guojiufu at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-03-19 4:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93709
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jiu Fu Guo
<guojiufu@gcc.gnu.org>:
https://gcc.gnu.org/g:d01cb80e0fbe23510a861faab9909b76837faf98
commit r9-8401-gd01cb80e0fbe23510a861faab9909b76837faf98
Author: Jiufu Guo <guojiufu@linux.ibm.com>
Date: Tue Mar 10 13:51:57 2020 +0800
rs6000: Check -+0 and NaN for smax/smin generation
PR93709 mentioned regressions on maxlocval_4.f90 and minlocval_f.f90 which
relates to max of '-inf' and 'nan'. This regression occur on P9 because
P9 new instruction 'xsmaxcdp' is generated.
And for C code `a < b ? b : a` is also generated as `xsmaxcdp` under -O2
for P9. While this instruction behavior more like C/C++ semantic (a>b?a:b).
In GCC9, the issue also occur as the new test case shows.
This generates prevents 'xsmaxcdp' to be generated for those cases.
'xsmincdp' also is handled in patch.
gcc/
2020-03-19 Jiufu Guo <guojiufu@linux.ibm.com>
PR target/93709
* gcc/config/rs6000/rs6000.c (rs6000_emit_p9_fp_minmax): Check
NAN and SIGNED_ZEROR for smax/smin.
gcc/testsuite
2020-03-19 Jiufu Guo <guojiufu@linux.ibm.com>
PR target/93709
* gcc.target/powerpc/p9-minmax-3.c: New test.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug target/93709] [10 regression] fortran.dg/minlocval_4.f90 fails on power 9 after r10-4161
[not found] <bug-93709-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-03-19 4:58 ` cvs-commit at gcc dot gnu.org
@ 2020-03-19 13:32 ` guojiufu at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: guojiufu at gcc dot gnu.org @ 2020-03-19 13:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93709
Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #9 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
submit to trunk and GCC9.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-19 13:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-93709-4@http.gcc.gnu.org/bugzilla/>
2020-03-11 12:05 ` [Bug target/93709] [10 regression] fortran.dg/minlocval_4.f90 fails on power 9 after r10-4161 marxin at gcc dot gnu.org
2020-03-11 15:38 ` wschmidt at gcc dot gnu.org
2020-03-19 4:58 ` cvs-commit at gcc dot gnu.org
2020-03-19 13:32 ` guojiufu at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).