public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/93771] SLP produces VEC_PERM when should have used vector generation
Date: Fri, 12 May 2023 06:01:09 +0000	[thread overview]
Message-ID: <bug-93771-4-W3crhDsQR7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93771-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93771

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |11.0

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note the aarch64 code generation for this code is not so bad right now:

        ldp     q0, q2, [x1]
        ldr     q1, [x2]
        ins     v0.d[1], v2.d[1]
        fadd    v0.2d, v0.2d, v1.2d
        str     q0, [x0]

Because the PERM
  vect__1.7_17 = VEC_PERM_EXPR <vect__1.5_14, vect__1.6_16, { 0, 3 }>;
does the correct thing of doing just the ins now (by
r11-2192-gc9c87e6f9c795bb36e4570a07 )

x86_64 code generation is not bad either:
        movupd  16(%rsi), %xmm0
        movupd  (%rdx), %xmm1
        movlpd  (%rsi), %xmm0
        addpd   %xmm1, %xmm0
        movups  %xmm0, (%rdi)

So I am just going to close this as fixed really.

           reply	other threads:[~2023-05-12  6:01 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <bug-93771-4@http.gcc.gnu.org/bugzilla/>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93771-4-W3crhDsQR7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).