public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/93826] [OpenMP][OpenACC] Collapsed loop – code silently ignored
Date: Thu, 06 Aug 2020 09:32:42 +0000	[thread overview]
Message-ID: <bug-93826-4-A4pwpmL4pM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93826-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93826

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Missed to list the PR in the commit :-(

* OpenMP 4.5 patch which rejects this is the following:
https://gcc.gnu.org/pipermail/gcc-patches/2020-August/551338.html
and https://gcc.gnu.org/g:57dd9f3bfca8bb752c630431dc033c761e2ad382 (= r11-2553)

→ FIXED for OpenMP (4.5)
-------------
Tue, 4 Aug 2020 16:17:53 +0000 (18:17 +0200)
Fortran/OpenMP: Fix detecting not perfectly nested loops

gcc/fortran/ChangeLog:

* openmp.c (resolve_omp_do): Detect not perfectly
nested loop with innermost collapse.

gcc/testsuite/ChangeLog:

* gfortran.dg/gomp/collapse1.f90: Add dg-error.
* gfortran.dg/gomp/collapse2.f90: New test.
-------------


TODO:

* OpenMP 5.x permits this (see also review comment)

* OpenACC: Still needs to be rejected

  parent reply	other threads:[~2020-08-06  9:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93826-4@http.gcc.gnu.org/bugzilla/>
2020-05-22  8:03 ` burnus at gcc dot gnu.org
2020-05-22  8:14 ` burnus at gcc dot gnu.org
2020-05-22  8:37 ` burnus at gcc dot gnu.org
2020-08-06  9:32 ` burnus at gcc dot gnu.org [this message]
2020-08-06 12:53 ` dominiq at lps dot ens.fr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93826-4-A4pwpmL4pM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).