public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug inline-asm/93903] invalid input constraint in __asm__
[not found] <bug-93903-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-15 19:30 ` frederic.recoules@univ-grenoble-alpes.fr
2021-09-14 21:00 ` [Bug middle-end/93903] space in constraint for inline-asm not ignored after all pinskia at gcc dot gnu.org
1 sibling, 0 replies; 2+ messages in thread
From: frederic.recoules@univ-grenoble-alpes.fr @ 2020-03-15 19:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93903
Frédéric Recoules <frederic.recoules@univ-grenoble-alpes.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |frederic.recoules@univ-gren
| |oble-alpes.fr
--- Comment #2 from Frédéric Recoules <frederic.recoules@univ-grenoble-alpes.fr> ---
(In reply to Frédéric Recoules from comment #1)
> I am pretty sure the error comes from the space you left in "r ".
> Yet, in the "Simple-Constraints" documentation, it is said that space are
> ignored
> to allow visual alignment but, in fact, I realized a while ago it generates
> an error.
>
> I think it would not be a big change to either update the documentation at
> https://gcc.gnu.org/onlinedocs/gcc/Simple-Constraints.html#Simple-
> Constraints or to make the parser ignore the blank.
I read me again and see how my comment was useless but, I really wanted to
help.
In fact I found that space are authorized for output but not for input.
In the file stmt.c:
In the function parse_input_constraint, the default case starts with:
if (!ISALPHA (*p))
break;
So it just exits the switch and continue, while the default case of
parse_input_constraint starts with:
if (! ISALPHA (constraint[j]))
{
error ("invalid punctuation %qc in constraint", constraint[j]);
return false;
}
Yet, I would add in the switch for both:
case ' ':
break;
^ permalink raw reply [flat|nested] 2+ messages in thread* [Bug middle-end/93903] space in constraint for inline-asm not ignored after all
[not found] <bug-93903-4@http.gcc.gnu.org/bugzilla/>
2020-03-15 19:30 ` [Bug inline-asm/93903] invalid input constraint in __asm__ frederic.recoules@univ-grenoble-alpes.fr
@ 2021-09-14 21:00 ` pinskia at gcc dot gnu.org
1 sibling, 0 replies; 2+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-14 21:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93903
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-09-14
Component|inline-asm |middle-end
Summary|invalid input constraint in |space in constraint for
|__asm__ |inline-asm not ignored
| |after all
Ever confirmed|0 |1
Keywords| |rejects-valid
Status|UNCONFIRMED |NEW
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-14 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-93903-4@http.gcc.gnu.org/bugzilla/>
2020-03-15 19:30 ` [Bug inline-asm/93903] invalid input constraint in __asm__ frederic.recoules@univ-grenoble-alpes.fr
2021-09-14 21:00 ` [Bug middle-end/93903] space in constraint for inline-asm not ignored after all pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).