public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
@ 2020-04-25 12:18 ` tkoenig at gcc dot gnu.org
2020-04-25 15:59 ` dominiq at lps dot ens.fr
` (14 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-04-25 12:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-04-25
CC| |tkoenig at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #1 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
2020-04-25 12:18 ` [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer tkoenig at gcc dot gnu.org
@ 2020-04-25 15:59 ` dominiq at lps dot ens.fr
2021-01-26 7:16 ` mscfd at gmx dot net
` (13 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-04-25 15:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Up to revion r242391 I get the error:
function selector() result(f)
1
Error: CLASS variable 'f' at (1) must be dummy, allocatable or pointer
pr93924.f90:29:19:
function apply(f, x) result(y)
1
Error: CLASS variable 'f' at (1) must be dummy, allocatable or pointer
pr93924.f90:51:4:
use cs
1
Fatal Error: Can't open module file 'cs.mod' for reading at (1): No such file
or directory
compilation terminated.
I see the ICE at revision r242749.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
2020-04-25 12:18 ` [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer tkoenig at gcc dot gnu.org
2020-04-25 15:59 ` dominiq at lps dot ens.fr
@ 2021-01-26 7:16 ` mscfd at gmx dot net
2021-01-26 7:19 ` mscfd at gmx dot net
` (12 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: mscfd at gmx dot net @ 2021-01-26 7:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #3 from martin <mscfd at gmx dot net> ---
The submitted testcase is invalid fortran, see bug 93925. However, with the
same small fix it becomes valid and still fails. Sorry for the mistake.
Instead of a fix, I have attached a much reduced testcase showing the same
failure.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2021-01-26 7:16 ` mscfd at gmx dot net
@ 2021-01-26 7:19 ` mscfd at gmx dot net
2021-01-26 8:21 ` tkoenig at gcc dot gnu.org
` (11 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: mscfd at gmx dot net @ 2021-01-26 7:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #4 from martin <mscfd at gmx dot net> ---
Created attachment 50053
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50053&action=edit
reduced testcase
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2021-01-26 7:19 ` mscfd at gmx dot net
@ 2021-01-26 8:21 ` tkoenig at gcc dot gnu.org
2021-01-26 8:23 ` tkoenig at gcc dot gnu.org
` (10 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2021-01-26 8:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pault at gcc dot gnu.org
--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Paul, you've been fixing so many CLASS errors, maybe you'd like
about this one :-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2021-01-26 8:21 ` tkoenig at gcc dot gnu.org
@ 2021-01-26 8:23 ` tkoenig at gcc dot gnu.org
2021-01-26 9:02 ` [Bug fortran/93924] [OOP] segfault with function returning a CLASS(*) pointer mscfd at gmx dot net
` (9 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2021-01-26 8:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #6 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
This actually segfaults at runtime.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] segfault with function returning a CLASS(*) pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2021-01-26 8:23 ` tkoenig at gcc dot gnu.org
@ 2021-01-26 9:02 ` mscfd at gmx dot net
2021-01-26 9:03 ` [Bug fortran/93924] [OOP] ICE with procedure pointer tkoenig at gcc dot gnu.org
` (8 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: mscfd at gmx dot net @ 2021-01-26 9:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #7 from martin <mscfd at gmx dot net> ---
With a recent gfortran version I get (how did you compile that you can run the
code):
fun_select.f90:37:15:
37 | f => selector()
| 1
internal compiler error: Segmentation fault
0xc1f3af crash_signal
../../gcc-repo/gcc/toplev.c:327
0x7842f2 gfc_class_vptr_get(tree_node*)
../../gcc-repo/gcc/fortran/trans-expr.c:205
0x797d7c trans_class_vptr_len_assignment
../../gcc-repo/gcc/fortran/trans-expr.c:9202
0x799afa trans_class_assignment
../../gcc-repo/gcc/fortran/trans-expr.c:10893
0x799afa gfc_trans_assignment_1
../../gcc-repo/gcc/fortran/trans-expr.c:11326
0x757d77 trans_code
../../gcc-repo/gcc/fortran/trans.c:1919
0x781a99 gfc_generate_function_code(gfc_namespace*)
../../gcc-repo/gcc/fortran/trans-decl.c:6880
0x6fd80e translate_all_program_units
../../gcc-repo/gcc/fortran/parse.c:6351
0x6fd80e gfc_parse_file()
../../gcc-repo/gcc/fortran/parse.c:6620
0x75504f gfc_be_parse_file
../../gcc-repo/gcc/fortran/f95-lang.c:212
Please submit a full bug report,
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2021-01-26 9:02 ` [Bug fortran/93924] [OOP] segfault with function returning a CLASS(*) pointer mscfd at gmx dot net
@ 2021-01-26 9:03 ` tkoenig at gcc dot gnu.org
2021-01-26 12:44 ` pault at gcc dot gnu.org
` (7 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2021-01-26 9:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[OOP] segfault with |[OOP] ICE with procedure
|function returning a |pointer
|CLASS(*) pointer |
Keywords|wrong-code |ice-on-valid-code
--- Comment #8 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Sorry, I got the PRs mixed up here and edited the wrong one :-(
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2021-01-26 9:03 ` [Bug fortran/93924] [OOP] ICE with procedure pointer tkoenig at gcc dot gnu.org
@ 2021-01-26 12:44 ` pault at gcc dot gnu.org
2021-01-26 15:17 ` pault at gcc dot gnu.org
` (6 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: pault at gcc dot gnu.org @ 2021-01-26 12:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #9 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 50057
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50057&action=edit
Patch that "fixes" all versions of the problem
The attached patch has a fragment of my finalize on assignment patch in the
second chunk. The changes are small and few so could be applied manually.
Whatever is the legality or otherwise, this fixes all versions of the problem
and regtests OK.
Please do what you will with this. If it is still open in a few weeks time, I
will take it. At the present, I have too many open PRs.
Paul
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2021-01-26 12:44 ` pault at gcc dot gnu.org
@ 2021-01-26 15:17 ` pault at gcc dot gnu.org
2021-01-27 11:07 ` pault at gcc dot gnu.org
` (5 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: pault at gcc dot gnu.org @ 2021-01-26 15:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #10 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Paul Thomas from comment #9)
> Created attachment 50057 [details]
> Patch that "fixes" all versions of the problem
>
> The attached patch has a fragment of my finalize on assignment patch in the
> second chunk. The changes are small and few so could be applied manually.
>
> Whatever is the legality or otherwise, this fixes all versions of the
> problem and regtests OK.
>
> Please do what you will with this. If it is still open in a few weeks time,
> I will take it. At the present, I have too many open PRs.
>
> Paul
Final remarks for the time being in comments below:
module cs
implicit none
private
public classStar_map_ifc
public apply, selector
integer, target :: integer_target
abstract interface
function classStar_map_ifc(x) result(y)
class(*), pointer :: y
class(*), target, intent(in) :: x
end function classStar_map_ifc
end interface
contains
function fun(x) result(y)
class(*), pointer :: y
class(*), target, intent(in) :: x
select type (x)
type is (integer)
integer_target = x ! One way of overcoming dangling target business
y => integer_target
class default
y => null()
end select
end function fun
function apply(f, x) result(y)
procedure(classStar_map_ifc) :: f
integer, intent(in) :: x
integer :: y
class(*), pointer :: p
y = 0 ! Get rid of 'y' undefined warning
p => f(x)
select type (p)
type is (integer)
y = p
end select
end function apply
function selector() result(f)
procedure(classStar_map_ifc), pointer :: f
f => fun
end function selector
end module cs
program classStar_map
use cs
implicit none
integer :: x, y
procedure(classStar_map_ifc), pointer :: f
x = 123654
f => selector() ! Fixed by second chunk in patch (suppresses
class assignment)
y = apply(f, x) ! Fixed by first chunk in patch (passing
procedure)
print *, x, y
end program classStar_map
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2021-01-26 15:17 ` pault at gcc dot gnu.org
@ 2021-01-27 11:07 ` pault at gcc dot gnu.org
2021-01-27 11:34 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: pault at gcc dot gnu.org @ 2021-01-27 11:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |pault at gcc dot gnu.org
--- Comment #11 from Paul Thomas <pault at gcc dot gnu.org> ---
Ah, go on! It's on my tree - I'll commit as obvious.
Paul
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2021-01-27 11:07 ` pault at gcc dot gnu.org
@ 2021-01-27 11:34 ` cvs-commit at gcc dot gnu.org
2021-05-04 12:31 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-01-27 11:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:
https://gcc.gnu.org/g:4225af228b5d52e8d7593dea49584c91b4bc2e1f
commit r11-6928-g4225af228b5d52e8d7593dea49584c91b4bc2e1f
Author: Paul Thomas <pault@gcc.gnu.org>
Date: Wed Jan 27 11:34:02 2021 +0000
Fortran: Fix ICE due to elemental procedure pointers [PR93924/5].
2021-01-27 Paul Thomas <pault@gcc.gnu.org>
gcc/fortran
PR fortran/93924
PR fortran/93925
* trans-expr.c (gfc_conv_procedure_call): Suppress the call to
gfc_conv_intrinsic_to_class for unlimited polymorphic procedure
pointers.
(gfc_trans_assignment_1): Similarly suppress class assignment
for class valued procedure pointers.
gcc/testsuite/
PR fortran/93924
PR fortran/93925
* gfortran.dg/proc_ptr_52.f90 : New test.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2021-01-27 11:34 ` cvs-commit at gcc dot gnu.org
@ 2021-05-04 12:31 ` rguenth at gcc dot gnu.org
2021-08-28 19:57 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-05-04 12:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2021-05-04 12:31 ` rguenth at gcc dot gnu.org
@ 2021-08-28 19:57 ` cvs-commit at gcc dot gnu.org
2021-09-06 18:43 ` cvs-commit at gcc dot gnu.org
2021-09-06 18:47 ` anlauf at gcc dot gnu.org
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-28 19:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:bf22e268b5c2a03216503254cfcb828016a7d998
commit r10-10077-gbf22e268b5c2a03216503254cfcb828016a7d998
Author: Paul Thomas <pault@gcc.gnu.org>
Date: Wed Jan 27 11:34:02 2021 +0000
Fortran: Fix ICE due to elemental procedure pointers [PR93924/5].
2021-01-27 Paul Thomas <pault@gcc.gnu.org>
gcc/fortran
PR fortran/93924
PR fortran/93925
* trans-expr.c (gfc_conv_procedure_call): Suppress the call to
gfc_conv_intrinsic_to_class for unlimited polymorphic procedure
pointers.
(gfc_trans_assignment_1): Similarly suppress class assignment
for class valued procedure pointers.
gcc/testsuite/
PR fortran/93924
PR fortran/93925
* gfortran.dg/proc_ptr_52.f90 : New test.
(cherry picked from commit 4225af228b5d52e8d7593dea49584c91b4bc2e1f)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2021-08-28 19:57 ` cvs-commit at gcc dot gnu.org
@ 2021-09-06 18:43 ` cvs-commit at gcc dot gnu.org
2021-09-06 18:47 ` anlauf at gcc dot gnu.org
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-06 18:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:49cefbec30499da06f90912090bcc5eabdfefa32
commit r9-9710-g49cefbec30499da06f90912090bcc5eabdfefa32
Author: Paul Thomas <pault@gcc.gnu.org>
Date: Wed Jan 27 11:34:02 2021 +0000
Fortran: Fix ICE due to elemental procedure pointers [PR93924/5].
2021-01-27 Paul Thomas <pault@gcc.gnu.org>
gcc/fortran
PR fortran/93924
PR fortran/93925
* trans-expr.c (gfc_conv_procedure_call): Suppress the call to
gfc_conv_intrinsic_to_class for unlimited polymorphic procedure
pointers.
(gfc_trans_assignment_1): Similarly suppress class assignment
for class valued procedure pointers.
gcc/testsuite/
PR fortran/93924
PR fortran/93925
* gfortran.dg/proc_ptr_52.f90 : New test.
(cherry picked from commit 4225af228b5d52e8d7593dea49584c91b4bc2e1f)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/93924] [OOP] ICE with procedure pointer
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
` (14 preceding siblings ...)
2021-09-06 18:43 ` cvs-commit at gcc dot gnu.org
@ 2021-09-06 18:47 ` anlauf at gcc dot gnu.org
15 siblings, 0 replies; 16+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-09-06 18:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93924
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anlauf at gcc dot gnu.org
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #15 from anlauf at gcc dot gnu.org ---
Should be fixed on all open branches. Closing.
Thanks for the report!
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-09-06 18:47 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-93924-4@http.gcc.gnu.org/bugzilla/>
2020-04-25 12:18 ` [Bug fortran/93924] ICE in gfc_class_len_get at trans_expr.c:231 with function returning a procedure pointer tkoenig at gcc dot gnu.org
2020-04-25 15:59 ` dominiq at lps dot ens.fr
2021-01-26 7:16 ` mscfd at gmx dot net
2021-01-26 7:19 ` mscfd at gmx dot net
2021-01-26 8:21 ` tkoenig at gcc dot gnu.org
2021-01-26 8:23 ` tkoenig at gcc dot gnu.org
2021-01-26 9:02 ` [Bug fortran/93924] [OOP] segfault with function returning a CLASS(*) pointer mscfd at gmx dot net
2021-01-26 9:03 ` [Bug fortran/93924] [OOP] ICE with procedure pointer tkoenig at gcc dot gnu.org
2021-01-26 12:44 ` pault at gcc dot gnu.org
2021-01-26 15:17 ` pault at gcc dot gnu.org
2021-01-27 11:07 ` pault at gcc dot gnu.org
2021-01-27 11:34 ` cvs-commit at gcc dot gnu.org
2021-05-04 12:31 ` rguenth at gcc dot gnu.org
2021-08-28 19:57 ` cvs-commit at gcc dot gnu.org
2021-09-06 18:43 ` cvs-commit at gcc dot gnu.org
2021-09-06 18:47 ` anlauf at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).