public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/93930] [8/9/10 Regression] Unnecessary broadcast instructions for AVX512
Date: Mon, 09 Mar 2020 15:19:28 +0000	[thread overview]
Message-ID: <bug-93930-4-PvLG6PE5DE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93930-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93930

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The cost changes affect the RTL LIM.-Set in insn 22 is invariant (0), cost 32,
depends on 
-Set in insn 27 is invariant (1), cost 32, depends on 
-Set in insn 32 is invariant (2), cost 32, depends on 
-Set in insn 37 is invariant (3), cost 32, depends on 
-Set in insn 61 is invariant (4), cost 32, depends on 
-Set in insn 66 is invariant (5), cost 32, depends on 
-Set in insn 71 is invariant (6), cost 32, depends on 
-Set in insn 76 is invariant (7), cost 32, depends on 
-Set in insn 101 is invariant (8), cost 32, depends on 
-Set in insn 106 is invariant (9), cost 32, depends on 
-Set in insn 111 is invariant (10), cost 32, depends on 
-Set in insn 116 is invariant (11), cost 32, depends on 
-Decided to move invariant 0 -- gain 32
-Decided to move invariant 1 -- gain 32
-Decided to move invariant 2 -- gain 32
-Decided to move invariant 3 -- gain 32
-Decided to move invariant 4 -- gain 32
-Decided to move invariant 5 -- gain 32
-Decided to move invariant 6 -- gain 32
-Decided to move invariant 7 -- gain 32
-Decided to move invariant 8 -- gain 32
-Decided to move invariant 9 -- gain 32
-Decided to move invariant 10 -- gain 10
-Decided to move invariant 11 -- gain 30
+Set in insn 22 is invariant (0), cost 4, depends on 
+Set in insn 27 is invariant (1), cost 4, depends on 
+Set in insn 32 is invariant (2), cost 4, depends on 
+Set in insn 37 is invariant (3), cost 4, depends on 
+Set in insn 61 is invariant (4), cost 4, depends on 
+Set in insn 66 is invariant (5), cost 4, depends on 
+Set in insn 71 is invariant (6), cost 4, depends on 
+Set in insn 76 is invariant (7), cost 4, depends on 
+Set in insn 101 is invariant (8), cost 4, depends on 
+Set in insn 106 is invariant (9), cost 4, depends on 
+Set in insn 111 is invariant (10), cost 4, depends on 
+Set in insn 116 is invariant (11), cost 4, depends on 
+Decided to move invariant 0 -- gain 4
+Decided to move invariant 1 -- gain 4
+Decided to move invariant 2 -- gain 4
+Decided to move invariant 3 -- gain 4
+Decided to move invariant 4 -- gain 4
+Decided to move invariant 5 -- gain 4
+Decided to move invariant 6 -- gain 4
+Decided to move invariant 7 -- gain 4
+Decided to move invariant 8 -- gain 4
+Decided to move invariant 9 -- gain 4
which means invariant 10 and 11 aren't moved anymore.
Those two are:
-(insn 111 106 116 3 (set (reg:V16SF 210)
-        (vec_duplicate:V16SF (vec_select:SF (reg:V4SF 234)
-                (parallel [
-                        (const_int 0 [0])
-                    ])))) "include/avx512fintrin.h":207 4206
{avx512f_vec_dupv16sf}
-     (expr_list:REG_EQUAL (const_vector:V16SF [
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-                (const_double:SF 2.3e+1 [0x0.b8p+5])
-            ])
-        (nil)))
-(insn 116 111 139 3 (set (reg:V16SF 214)
-        (vec_duplicate:V16SF (vec_select:SF (reg:V4SF 235)
-                (parallel [
-                        (const_int 0 [0])
-                    ])))) "include/avx512fintrin.h":207 4206
{avx512f_vec_dupv16sf}
-     (expr_list:REG_EQUAL (const_vector:V16SF [
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-                (const_double:SF 2.4e+1 [0x0.cp+5])
-            ])
-        (nil)))
and I bet the reason they are using the const costs are the REG_EQUAL notes.
The setters of their sources are:
(insn 169 168 170 3 (set (reg:V4SF 234)
        (mem/u/c:V4SF (symbol_ref/u:DI ("*.LC10") [flags 0x2]) [2  S16 A128]))
-1
     (expr_list:REG_EQUAL (const_vector:V4SF [
                (const_double:SF 2.3e+1 [0x0.b8p+5])
                (const_double:SF 0.0 [0x0.0p+0])
                (const_double:SF 0.0 [0x0.0p+0])
                (const_double:SF 0.0 [0x0.0p+0])
            ])
        (nil)))
(insn 170 169 22 3 (set (reg:V4SF 235)
        (mem/u/c:V4SF (symbol_ref/u:DI ("*.LC11") [flags 0x2]) [2  S16 A128]))
-1
     (expr_list:REG_EQUAL (const_vector:V4SF [
                (const_double:SF 2.4e+1 [0x0.cp+5])
                (const_double:SF 0.0 [0x0.0p+0])
                (const_double:SF 0.0 [0x0.0p+0])
                (const_double:SF 0.0 [0x0.0p+0])
            ])
        (nil)))

       reply	other threads:[~2020-03-09 15:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93930-4@http.gcc.gnu.org/bugzilla/>
2020-03-09 15:19 ` jakub at gcc dot gnu.org [this message]
2021-05-14  9:53 ` [Bug target/93930] [9/10/11/12 " jakub at gcc dot gnu.org
2021-06-01  8:16 ` rguenth at gcc dot gnu.org
2022-05-27  9:42 ` [Bug target/93930] [10/11/12/13 " rguenth at gcc dot gnu.org
2022-06-28 10:39 ` jakub at gcc dot gnu.org
2023-07-07 10:37 ` [Bug target/93930] [11/12/13/14 " rguenth at gcc dot gnu.org
2024-02-21  4:04 ` pinskia at gcc dot gnu.org
2024-03-10 21:43 ` law at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93930-4-PvLG6PE5DE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).