From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id A0767385843A; Sun, 29 Aug 2021 09:14:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0767385843A From: "pinskia at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/93990] [x86] Silly code generation for _addcarry_u32/_addcarry_u64 Date: Sun, 29 Aug 2021 09:14:55 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 9.2.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: enhancement X-Bugzilla-Who: pinskia at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status bug_severity Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2021 09:14:55 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D93990 Andrew Pinski changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Severity|normal |enhancement --- Comment #5 from Andrew Pinski --- _addcarry_u64(0, a, c, &result0) can definitely be folded into __builtin_uadd_overflowll/.ADD_OVERFLOW without any troubles. The second _addcarry_u64 here since the result is not used can be folded in= to just an a few adds. That leaves if there case where the first argument is non-zero and the resu= lt is used. I think going the route that Jakub mentions is best for this last case.=