* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-09 14:26 ` vmakarov at gcc dot gnu.org
2020-03-09 14:35 ` segher at gcc dot gnu.org
` (21 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: vmakarov at gcc dot gnu.org @ 2020-03-09 14:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #29 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Sorry for all the troubles with my latest patch and thank you for fair
criticism. I've decided to revert the patch as soon as git starts working.
I'll work to find a better solution after this.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
2020-03-09 14:26 ` [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu vmakarov at gcc dot gnu.org
@ 2020-03-09 14:35 ` segher at gcc dot gnu.org
2020-03-09 14:37 ` marxin at gcc dot gnu.org
` (20 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 14:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #30 from Segher Boessenkool <segher at gcc dot gnu.org> ---
I cannot reproduce the problem, btw (I cannot build a 32-bit hosted toolchain).
Martin, you have a working recipe?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
2020-03-09 14:26 ` [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu vmakarov at gcc dot gnu.org
2020-03-09 14:35 ` segher at gcc dot gnu.org
@ 2020-03-09 14:37 ` marxin at gcc dot gnu.org
2020-03-09 14:44 ` segher at gcc dot gnu.org
` (19 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-09 14:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #31 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #30)
> I cannot reproduce the problem, btw (I cannot build a 32-bit hosted
> toolchain).
> Martin, you have a working recipe?
Go to gcc110 machine and do:
$ CC="gcc -m32" CXX="g++ -m32" ../configure --enable-languages=c,c++
--disable-lto
$ CC="gcc -m32" CXX="g++ -m32" make -j64 STAGE1_CFLAGS="-O2 -g"
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-03-09 14:37 ` marxin at gcc dot gnu.org
@ 2020-03-09 14:44 ` segher at gcc dot gnu.org
2020-03-09 14:47 ` segher at gcc dot gnu.org
` (18 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 14:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #32 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Sigh. No, this is *not* a target bug (or we certainly do not know it is),
please stop marking it that.
It seems to be a bug in shrink-wrapping, but the dump does not show enough
information (only contradictory info :-/ ), and I cannot yet reproduce the
problem.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-03-09 14:44 ` segher at gcc dot gnu.org
@ 2020-03-09 14:47 ` segher at gcc dot gnu.org
2020-03-09 14:48 ` segher at gcc dot gnu.org
` (17 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 14:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #33 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #31)
> (In reply to Segher Boessenkool from comment #30)
> > I cannot reproduce the problem, btw (I cannot build a 32-bit hosted
> > toolchain).
> > Martin, you have a working recipe?
>
> Go to gcc110 machine and do:
> $ CC="gcc -m32" CXX="g++ -m32" ../configure --enable-languages=c,c++
> --disable-lto
> $ CC="gcc -m32" CXX="g++ -m32" make -j64 STAGE1_CFLAGS="-O2 -g"
I did that (with /usr/bin/gcc etc. though, won't work at all otherwise),
but that builds stage2 as 64-bit?
Is that stage1 flags the secret sauce?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2020-03-09 14:47 ` segher at gcc dot gnu.org
@ 2020-03-09 14:48 ` segher at gcc dot gnu.org
2020-03-09 14:51 ` marxin at gcc dot gnu.org
` (16 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 14:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #34 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Vladimir Makarov from comment #29)
> Sorry for all the troubles with my latest patch and thank you for fair
> criticism. I've decided to revert the patch as soon as git starts working.
> I'll work to find a better solution after this.
Thanks! Btw, on powerpc64-linux your patch changed the allocation order
of the non-volatile registers, which is a big regression (we need bigger
stack frames that way).
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2020-03-09 14:48 ` segher at gcc dot gnu.org
@ 2020-03-09 14:51 ` marxin at gcc dot gnu.org
2020-03-09 17:52 ` segher at gcc dot gnu.org
` (15 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-09 14:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #35 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #33)
> (In reply to Martin Liška from comment #31)
> > (In reply to Segher Boessenkool from comment #30)
> > > I cannot reproduce the problem, btw (I cannot build a 32-bit hosted
> > > toolchain).
> > > Martin, you have a working recipe?
> >
> > Go to gcc110 machine and do:
> > $ CC="gcc -m32" CXX="g++ -m32" ../configure --enable-languages=c,c++
> > --disable-lto
> > $ CC="gcc -m32" CXX="g++ -m32" make -j64 STAGE1_CFLAGS="-O2 -g"
>
> I did that (with /usr/bin/gcc etc. though, won't work at all otherwise),
> but that builds stage2 as 64-bit?
Hm, that's possible. But the stage2 should not crash right?
>
> Is that stage1 flags the secret sauce?
No that's not the secret sauce.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2020-03-09 14:51 ` marxin at gcc dot gnu.org
@ 2020-03-09 17:52 ` segher at gcc dot gnu.org
2020-03-09 17:53 ` segher at gcc dot gnu.org
` (14 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 17:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #36 from Segher Boessenkool <segher at gcc dot gnu.org> ---
> > I did that (with /usr/bin/gcc etc. though, won't work at all otherwise),
> > but that builds stage2 as 64-bit?
>
> Hm, that's possible. But the stage2 should not crash right?
It doesn't work, of course (mixed 32-bit and 64-bit thing).
And I need a 32-bit stage2 in any case, to have a compiler that miscompiles
pt.c:tsubst_template_arg, to figure out why it thinks it as allowed to use
GPR0 somewhere it obviously is live.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2020-03-09 17:52 ` segher at gcc dot gnu.org
@ 2020-03-09 17:53 ` segher at gcc dot gnu.org
2020-03-09 17:54 ` segher at gcc dot gnu.org
` (13 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 17:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #37 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Oh wait. I am dumb I guess? You did those dumps with a stage1 compiler?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2020-03-09 17:53 ` segher at gcc dot gnu.org
@ 2020-03-09 17:54 ` segher at gcc dot gnu.org
2020-03-09 18:09 ` vmakarov at gcc dot gnu.org
` (12 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 17:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #38 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Then, how did you do that?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2020-03-09 17:54 ` segher at gcc dot gnu.org
@ 2020-03-09 18:09 ` vmakarov at gcc dot gnu.org
2020-03-09 18:15 ` marxin at gcc dot gnu.org
` (11 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: vmakarov at gcc dot gnu.org @ 2020-03-09 18:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #39 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
I've reverted the patch in trouble:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commitdiff;h=5dc1390b41db5c1765e25fd21dad1a930a015aac
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2020-03-09 18:09 ` vmakarov at gcc dot gnu.org
@ 2020-03-09 18:15 ` marxin at gcc dot gnu.org
2020-03-09 18:40 ` marxin at gcc dot gnu.org
` (10 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-09 18:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #40 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #36)
> > > I did that (with /usr/bin/gcc etc. though, won't work at all otherwise),
> > > but that builds stage2 as 64-bit?
> >
> > Hm, that's possible. But the stage2 should not crash right?
>
> It doesn't work, of course (mixed 32-bit and 64-bit thing).
>
> And I need a 32-bit stage2 in any case, to have a compiler that miscompiles
> pt.c:tsubst_template_arg, to figure out why it thinks it as allowed to use
> GPR0 somewhere it obviously is live.
Ok, I've just run the build on gcc110 machine and you take a look at
/tmp/build.log. You are right that, using CC="gcc -m32" will cause that stage1
compiler is a cross from powerpc to powerpc64.
The miscompiled compiler is stage2:
$ file ./xgcc
./xgcc: ELF 64-bit MSB executable, 64-bit PowerPC or cisco 7500, version 1
(SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, not
stripped
and it ICEs on a simple test-case:
$ ./xgcc -B. /tmp/reduced.ii
/tmp/reduced.ii: In substitution of ‘template<bool <anonymous>, class> struct
__enable_if [with bool <anonymous> = true; <template-parameter-1-2> = _Tp]’:
/tmp/reduced.ii:5:24: required from here
/tmp/reduced.ii:5:24: internal compiler error: Segmentation fault
5 | struct __enable_if<true, _Tp>
| ^~~~~~~~~~~~~~~~~~~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
$ cat /tmp/reduced.ii
template<bool, typename>
struct __enable_if
{ };
template<typename _Tp>
struct __enable_if<true, _Tp>
{ typedef _Tp __type; };
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2020-03-09 18:15 ` marxin at gcc dot gnu.org
@ 2020-03-09 18:40 ` marxin at gcc dot gnu.org
2020-03-09 21:35 ` segher at gcc dot gnu.org
` (9 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-09 18:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #41 from Martin Liška <marxin at gcc dot gnu.org> ---
Ok, the way how we build our compiler is to use:
./configure --with-cpu=default32
that should also lead to the ICE. I'm checking that.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2020-03-09 18:40 ` marxin at gcc dot gnu.org
@ 2020-03-09 21:35 ` segher at gcc dot gnu.org
2020-03-10 8:51 ` marxin at gcc dot gnu.org
` (8 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-09 21:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #42 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Okay, I see your dumps are 64-bit as well. But mine are very different, huh.
Still, it crashes in pretty much the same way.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2020-03-09 21:35 ` segher at gcc dot gnu.org
@ 2020-03-10 8:51 ` marxin at gcc dot gnu.org
2020-03-10 8:57 ` jakub at gcc dot gnu.org
` (7 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-10 8:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #43 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #41)
> Ok, the way how we build our compiler is to use:
> ./configure --with-cpu=default32
>
> that should also lead to the ICE. I'm checking that.
So this one crashes for stage3 compiler as well:
$ ./gcc/xgcc -Bgcc /tmp/reduced.ii
/tmp/reduced.ii: In substitution of ‘template<bool <anonymous>, class> struct
__enable_if [with bool <anonymous> = true; <template-parameter-1-2> = _Tp]’:
/tmp/reduced.ii:5:24: required from here
/tmp/reduced.ii:5:24: internal compiler error: Segmentation fault
5 | struct __enable_if<true, _Tp>
| ^~~~~~~~~~~~~~~~~~~~~~
0x10cbb63f crash_signal
../../gcc/toplev.c:328
0x1041f45c contains_struct_check(tree_node*, tree_node_structure_enum, char
const*, int, char const*)
../../gcc/tree.h:3391
...
$ cat stage_current
stage3
$ file ./gcc/xgcc
./gcc/xgcc: ELF 32-bit MSB executable, PowerPC or cisco 4500, version 1 (SYSV),
dynamically linked (uses shared libs), for GNU/Linux 2.6.32, with unknown
capability 0x41000000 = 0x11676e75, with unknown capability 0x10000 = 0x90401,
not stripped
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (14 preceding siblings ...)
2020-03-10 8:51 ` marxin at gcc dot gnu.org
@ 2020-03-10 8:57 ` jakub at gcc dot gnu.org
2020-03-10 9:00 ` marxin at gcc dot gnu.org
` (6 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-03-10 8:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #44 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So, with the reversion, can this be closed as FIXED?
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (15 preceding siblings ...)
2020-03-10 8:57 ` jakub at gcc dot gnu.org
@ 2020-03-10 9:00 ` marxin at gcc dot gnu.org
2020-03-10 15:13 ` segher at gcc dot gnu.org
` (5 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-10 9:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #45 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #44)
> So, with the reversion, can this be closed as FIXED?
I bet no. There's probably an underlying shrink-wrapping issue and Segher is
investigating that.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (16 preceding siblings ...)
2020-03-10 9:00 ` marxin at gcc dot gnu.org
@ 2020-03-10 15:13 ` segher at gcc dot gnu.org
2020-03-10 15:16 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-10 15:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #46 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Thank you very much for that new testcase! I wish I had it before :-)
Yesterday I found the problem. It is in separate shrink-wrapping. The
fix is probably simple; hang on :-)
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (17 preceding siblings ...)
2020-03-10 15:13 ` segher at gcc dot gnu.org
@ 2020-03-10 15:16 ` marxin at gcc dot gnu.org
2020-03-13 17:54 ` segher at gcc dot gnu.org
` (3 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-10 15:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #47 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #46)
> Thank you very much for that new testcase! I wish I had it before :-)
Do you mean /tmp/reduced.ii ? Note that it's already mentioned in c#14.
>
> Yesterday I found the problem. It is in separate shrink-wrapping. The
> fix is probably simple; hang on :-)
Great to hear that! Nice cooperation.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (18 preceding siblings ...)
2020-03-10 15:16 ` marxin at gcc dot gnu.org
@ 2020-03-13 17:54 ` segher at gcc dot gnu.org
2020-03-13 17:55 ` segher at gcc dot gnu.org
` (2 subsequent siblings)
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-13 17:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target|powerpc64-suse-linux |powerpc*
Host|powerpc64-suse-linux |
Build|powerpc64-suse-linux |
--- Comment #48 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Solved on trunk
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (19 preceding siblings ...)
2020-03-13 17:54 ` segher at gcc dot gnu.org
@ 2020-03-13 17:55 ` segher at gcc dot gnu.org
2020-03-15 12:02 ` marxin at gcc dot gnu.org
2020-07-13 11:12 ` segher at gcc dot gnu.org
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-13 17:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #49 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (20 preceding siblings ...)
2020-03-13 17:55 ` segher at gcc dot gnu.org
@ 2020-03-15 12:02 ` marxin at gcc dot gnu.org
2020-07-13 11:12 ` segher at gcc dot gnu.org
22 siblings, 0 replies; 23+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-15 12:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
--- Comment #50 from Martin Liška <marxin at gcc dot gnu.org> ---
commit r10-7160-g5c7e6d4bdf879b437b43037e10453275acabf521
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date: Thu Mar 12 07:12:50 2020 +0000
df: Don't abuse bb->aux (PR94148, PR94042)
The df dataflow solvers use the aux field in the basic_block struct,
although that is reserved for any use by passes. And not only that,
it is required that you set all such fields to NULL before calling
the solvers, or you quietly get wrong results.
This changes the solvers to use a local array for last_change_age
instead, just like it already had a local array for last_visit_age.
PR rtl-optimization/94148
PR rtl-optimization/94042
* df-core.c (BB_LAST_CHANGE_AGE): Delete.
(df_worklist_propagate_forward): New parameter last_change_age, use
that instead of bb->aux.
(df_worklist_propagate_backward): Ditto.
(df_worklist_dataflow_doublequeue): Use a local array
last_change_age.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Bug target/94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
[not found] <bug-94042-4@http.gcc.gnu.org/bugzilla/>
` (21 preceding siblings ...)
2020-03-15 12:02 ` marxin at gcc dot gnu.org
@ 2020-07-13 11:12 ` segher at gcc dot gnu.org
22 siblings, 0 replies; 23+ messages in thread
From: segher at gcc dot gnu.org @ 2020-07-13 11:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
Bug 94042 depends on bug 94148, which changed state.
Bug 94148 Summary: The DF framework uses bb->aux, which is for passes only
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 23+ messages in thread