public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94043] [9/10 Regression] ICE in superloop_at_depth, at cfgloop.c:78
Date: Thu, 26 Mar 2020 08:26:47 +0000 [thread overview]
Message-ID: <bug-94043-4-1TehCH2fTe@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94043-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94043
--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Kewen Lin from comment #12)
> Created attachment 48122 [details]
> ppc64le tested patch
>
> Thanks Richi!
>
> A patch draft attached to ensure on the right track, also
> bootstrapped/regresstested. I tried to reproduce the case that the stmts for
> lane extracting is empty (due to folding) with test cases associated in that
> old commit but failed. I think we don't need to deal with it? The new copy
> assignment instead of the phi could not be caught by the LC-PHI check in
> expand_simple_operations.
+ /* Find all SSA NAMEs in stmts which is defined in current loop, create
+ PHIs for them, and replace them with phi results accordingly. */
+ for (gsi = gsi_start (stmts); !gsi_end_p (gsi); gsi_next (&gsi))
+ {
+ gimple *stmt = gsi_stmt (gsi);
+ update_stmt (stmt);
+
...
should not be necessary. What's missing in your patch is that when the
current code has computed vec_lhs it needs to create a LC PHI node for it
_before_ computing the lane extraction and instead use vec_lhs' there.
next prev parent reply other threads:[~2020-03-26 8:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-94043-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` jakub at gcc dot gnu.org
2020-03-17 14:36 ` marxin at gcc dot gnu.org
2020-03-18 2:49 ` linkw at gcc dot gnu.org
2020-03-20 2:56 ` linkw at gcc dot gnu.org
2020-03-20 7:06 ` rguenther at suse dot de
2020-03-20 7:14 ` linkw at gcc dot gnu.org
2020-03-20 7:22 ` rguenther at suse dot de
2020-03-22 8:39 ` linkw at gcc dot gnu.org
2020-03-23 13:21 ` rguenth at gcc dot gnu.org
2020-03-24 2:59 ` linkw at gcc dot gnu.org
2020-03-24 6:44 ` rguenther at suse dot de
2020-03-26 2:45 ` linkw at gcc dot gnu.org
2020-03-26 8:26 ` rguenth at gcc dot gnu.org [this message]
2020-03-26 8:54 ` linkw at gcc dot gnu.org
2020-03-26 9:05 ` rguenther at suse dot de
2020-03-26 12:56 ` linkw at gcc dot gnu.org
2020-03-26 13:36 ` rguenth at gcc dot gnu.org
2020-04-01 5:24 ` cvs-commit at gcc dot gnu.org
2020-04-01 6:44 ` linkw at gcc dot gnu.org
2020-04-01 6:56 ` [Bug tree-optimization/94043] [9 " rguenth at gcc dot gnu.org
2020-04-01 7:30 ` linkw at gcc dot gnu.org
2020-04-02 13:21 ` clyon at gcc dot gnu.org
2020-04-17 8:55 ` cvs-commit at gcc dot gnu.org
2020-04-17 9:01 ` linkw at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-94043-4-1TehCH2fTe@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).