From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 6A0CE385E022; Thu, 26 Mar 2020 08:26:47 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A0CE385E022
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1585211207;
 bh=YDLlb4hKMZTo0x/7g9qpQ01xDzJY7GigsL93Tw2vjVw=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=QPS1SL2kDSJU0/LAmgBfkExFkVVetgagE63XylTRqdeqrSjQwYhDxrqLUixKBTM5Z
 x8yTykw38has/uRG5IzawTEQu9W8lg09UXYx2y9w6H55R7/Duutqo3PO+JoCQtYyIW
 sC0yNbB/2NU0B6KRJHOVs3M1tBoXvCLcyK/tmgLs=
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94043] [9/10 Regression] ICE in
 superloop_at_depth, at cfgloop.c:78
Date: Thu, 26 Mar 2020 08:26:47 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-94043-4-1TehCH2fTe@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94043-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94043-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <http://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2020 08:26:47 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94043

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Kewen Lin from comment #12)
> Created attachment 48122 [details]
> ppc64le tested patch
>=20
> Thanks Richi!
>=20
> A patch draft attached to ensure on the right track, also
> bootstrapped/regresstested. I tried to reproduce the case that the stmts =
for
> lane extracting is empty (due to folding) with test cases associated in t=
hat
> old commit but failed. I think we don't need to deal with it? The new copy
> assignment instead of the phi could not be caught by the LC-PHI check in
> expand_simple_operations.

+      /* Find all SSA NAMEs in stmts which is defined in current loop, cre=
ate
+        PHIs for them, and replace them with phi results accordingly.  */
+      for (gsi =3D gsi_start (stmts); !gsi_end_p (gsi); gsi_next (&gsi))
+       {
+         gimple *stmt =3D gsi_stmt (gsi);
+         update_stmt (stmt);
+
...

should not be necessary.  What's missing in your patch is that when the
current code has computed vec_lhs it needs to create a LC PHI node for it
_before_ computing the lane extraction and instead use vec_lhs' there.=