public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94043] [9/10 Regression] ICE in superloop_at_depth, at cfgloop.c:78
Date: Tue, 24 Mar 2020 02:59:35 +0000 [thread overview]
Message-ID: <bug-94043-4-GzQT2GhuB2@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94043-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94043
--- Comment #10 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #9)
> OK, so it's indeed vectorizable_live_operation not paying attention to
> loop-closed SSA form.
>
> What it should do before building the lane extract is create a _new_
> loop-closed PHI node for the vectorized def (vec_lhs), and then
> demote the loop-closed PHI node for the scalar def (lhs) which should
> _always_ exist to a copy. So from
>
>
> loop;
>
> # lhs' = PHI <lhs>
>
>
> go to
>
> loop;
>
> # vec_lhs' = PHI <vec_lhs>
> new_tree = BIT_FIELD_REF <vec_lhs', ...>;
> lhs' = new_tree;
>
> I think you can assert that the block of the loop-closed PHI
> (single_exit()->dest) always has a single predecessor, otherwise
> things will be more complicated.
>
> Can you try rework the code in this way? If that's too much just tell
> me and I'll take care of this.
Thanks Richi, I'll give it a shot!
I'd like to ensure my understanding: with the proposed fix, we ensure the
single_exit()->dest should be the correct BB to be inserted, no chance like
gimple_find_edge_insert_loc to get one new BB to be inserted, is it right?
next prev parent reply other threads:[~2020-03-24 2:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-94043-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` jakub at gcc dot gnu.org
2020-03-17 14:36 ` marxin at gcc dot gnu.org
2020-03-18 2:49 ` linkw at gcc dot gnu.org
2020-03-20 2:56 ` linkw at gcc dot gnu.org
2020-03-20 7:06 ` rguenther at suse dot de
2020-03-20 7:14 ` linkw at gcc dot gnu.org
2020-03-20 7:22 ` rguenther at suse dot de
2020-03-22 8:39 ` linkw at gcc dot gnu.org
2020-03-23 13:21 ` rguenth at gcc dot gnu.org
2020-03-24 2:59 ` linkw at gcc dot gnu.org [this message]
2020-03-24 6:44 ` rguenther at suse dot de
2020-03-26 2:45 ` linkw at gcc dot gnu.org
2020-03-26 8:26 ` rguenth at gcc dot gnu.org
2020-03-26 8:54 ` linkw at gcc dot gnu.org
2020-03-26 9:05 ` rguenther at suse dot de
2020-03-26 12:56 ` linkw at gcc dot gnu.org
2020-03-26 13:36 ` rguenth at gcc dot gnu.org
2020-04-01 5:24 ` cvs-commit at gcc dot gnu.org
2020-04-01 6:44 ` linkw at gcc dot gnu.org
2020-04-01 6:56 ` [Bug tree-optimization/94043] [9 " rguenth at gcc dot gnu.org
2020-04-01 7:30 ` linkw at gcc dot gnu.org
2020-04-02 13:21 ` clyon at gcc dot gnu.org
2020-04-17 8:55 ` cvs-commit at gcc dot gnu.org
2020-04-17 9:01 ` linkw at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-94043-4-GzQT2GhuB2@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).