public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/94043] [9/10 Regression] ICE in superloop_at_depth, at cfgloop.c:78 Date: Wed, 01 Apr 2020 05:24:10 +0000 [thread overview] Message-ID: <bug-94043-4-PPBnF6w1nX@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94043-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94043 --- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>: https://gcc.gnu.org/g:bd0f22a8d5caea8905f38ff1fafce31c1b7d33ad commit r10-7491-gbd0f22a8d5caea8905f38ff1fafce31c1b7d33ad Author: Kewen Lin <linkw@linux.ibm.com> Date: Tue Mar 31 22:48:46 2020 -0500 Fix PR94043 by making vect_live_op generate lc-phi As PR94043 shows, my commit r10-4524 exposed one issue in vectorizable_live_operation, which inserts one extra BB before the single exit, leading unexpected operand expansion and unexpected loop depth assertion. As Richi suggested, this patch is to teach vectorizable_live_operation to generate loop closed phi for vec_lhs, it looks like: loop; # lhs' = PHI <lhs> => loop; # vec_lhs' = PHI <vec_lhs> new_tree = BIT_FIELD_REF <vec_lhs', ...>; lhs' = new_tree; I noticed that there are some SLP cases that have same lhs and vec_lhs but different offsets, which can make us have more PHIs for the same vec_lhs there. But I think it would be fine since only one of them is actually live, the others should be eliminated by the following dce. So the patch doesn't check whether there is one phi for vec_lhs, just create one directly instead. Bootstrapped/regtested on powerpc64le-linux-gnu (LE) P8. 2020-04-01 Kewen Lin <linkw@gcc.gnu.org> gcc/ChangeLog PR tree-optimization/94043 * tree-vect-loop.c (vectorizable_live_operation): Generate loop-closed phi for vec_lhs and use it for lane extraction. gcc/testsuite/ChangeLog PR tree-optimization/94043 * gfortran.dg/graphite/vect-pr94043.f90: New test.
next prev parent reply other threads:[~2020-04-01 5:24 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-94043-4@http.gcc.gnu.org/bugzilla/> 2020-03-12 11:58 ` jakub at gcc dot gnu.org 2020-03-17 14:36 ` marxin at gcc dot gnu.org 2020-03-18 2:49 ` linkw at gcc dot gnu.org 2020-03-20 2:56 ` linkw at gcc dot gnu.org 2020-03-20 7:06 ` rguenther at suse dot de 2020-03-20 7:14 ` linkw at gcc dot gnu.org 2020-03-20 7:22 ` rguenther at suse dot de 2020-03-22 8:39 ` linkw at gcc dot gnu.org 2020-03-23 13:21 ` rguenth at gcc dot gnu.org 2020-03-24 2:59 ` linkw at gcc dot gnu.org 2020-03-24 6:44 ` rguenther at suse dot de 2020-03-26 2:45 ` linkw at gcc dot gnu.org 2020-03-26 8:26 ` rguenth at gcc dot gnu.org 2020-03-26 8:54 ` linkw at gcc dot gnu.org 2020-03-26 9:05 ` rguenther at suse dot de 2020-03-26 12:56 ` linkw at gcc dot gnu.org 2020-03-26 13:36 ` rguenth at gcc dot gnu.org 2020-04-01 5:24 ` cvs-commit at gcc dot gnu.org [this message] 2020-04-01 6:44 ` linkw at gcc dot gnu.org 2020-04-01 6:56 ` [Bug tree-optimization/94043] [9 " rguenth at gcc dot gnu.org 2020-04-01 7:30 ` linkw at gcc dot gnu.org 2020-04-02 13:21 ` clyon at gcc dot gnu.org 2020-04-17 8:55 ` cvs-commit at gcc dot gnu.org 2020-04-17 9:01 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94043-4-PPBnF6w1nX@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).