From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 76925385E009; Thu, 26 Mar 2020 09:05:51 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76925385E009
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1585213551;
 bh=+SdMTb0QHS1KM15cNGboGMRJ9SqCXBmLnaC36kXjljQ=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=GWCLRoPzkI4KMtcD+cTnbO+Shk4PtVH82It/5JYF3XTJq3WqQosimjrswMGlvH3dc
 X/d5l7S7gFB3Kqm2GmPSNvv7wBxDjNirc1eiOz7L3FcPGSrPYc+3BCypSfiasT0df9
 XZedmtTqL4qJG4zTJRbWEB3EDjx4yorW//ZrNSu8=
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94043] [9/10 Regression] ICE in
 superloop_at_depth, at cfgloop.c:78
Date: Thu, 26 Mar 2020 09:05:51 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenther at suse dot de
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-94043-4-mm3SLKapL0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94043-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94043-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <http://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2020 09:05:51 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94043

--- Comment #15 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 26 Mar 2020, linkw at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94043
>=20
> --- Comment #14 from Kewen Lin <linkw at gcc dot gnu.org> ---
> (In reply to Richard Biener from comment #13)
>=20
> >=20
> > +      /* Find all SSA NAMEs in stmts which is defined in current loop,
> > create
> > +        PHIs for them, and replace them with phi results accordingly. =
 */
> > +      for (gsi =3D gsi_start (stmts); !gsi_end_p (gsi); gsi_next (&gsi=
))
> > +       {
> > +         gimple *stmt =3D gsi_stmt (gsi);
> > +         update_stmt (stmt);
> > +
> > ...
> >=20
> > should not be necessary.  What's missing in your patch is that when the
> > current code has computed vec_lhs it needs to create a LC PHI node for =
it
> > _before_ computing the lane extraction and instead use vec_lhs' there.
>=20
> OK, I was thinking the mask for LOOP_VINFO_FULLY_MASKED_P part is probabl=
y a
> SSA name and can live out, as your comments, it looks impossible. Will up=
date
> it and send for review after testing. Thanks again!

I guess the result of vect_get_loop_mask might need a loop-closed PHI
as well though that could be addressed independently since it's a
pre-existing "bug"=