public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/94072] [10 Regression] ICE: SIGSEGV due to infinite recursion in expand_expr/expand_expr_real_1 with -msve-vector-bits=512 since r10-4197
Date: Fri, 20 Mar 2020 16:15:11 +0000	[thread overview]
Message-ID: <bug-94072-4-CivMPCszcA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94072-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94072

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:1aa22b1916a493ac46453d96e0c78ca47bcaeda3

commit r10-7301-g1aa22b1916a493ac46453d96e0c78ca47bcaeda3
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Tue Mar 17 14:43:08 2020 +0000

    c-family: Tighten vector handling in type_for_mode [PR94072]

    In this PR we had a 512-bit VECTOR_TYPE whose mode is XImode
    (an integer mode used for four 128-bit vectors).  When trying
    to expand a zero constant for it, we hit code in expand_expr_real_1
    that tries to use the associated integer type instead.  The code used
    type_for_mode (XImode, 1) to get this integer type.

    However, the c-family implementation of type_for_mode checks for
    any registered built-in type that matches the mode and has the
    right signedness.  This meant that it could return a built-in
    vector type when given an integer mode (particularly if, as here,
    the vector type isn't supported by the current subtarget and so
    TYPE_MODE != TYPE_MODE_RAW).  The expand code would then cycle
    endlessly trying to use this "new" type instead of the original
    vector type.

    2020-03-20  Richard Sandiford  <richard.sandiford@arm.com>

    gcc/c-family/
            PR middle-end/94072
            * c-common.c (c_common_type_for_mode): Before using a registered
            built-in type, check that the vectorness of the type matches
            the vectorness of the mode.

    gcc/testsuite/
            PR middle-end/94072
            * gcc.target/aarch64/pr94072.c: New test.

  parent reply	other threads:[~2020-03-20 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-94072-4@http.gcc.gnu.org/bugzilla/>
2020-03-09  8:07 ` [Bug target/94072] [10 Regression] ICE: SIGSEGV due to infinite recursion in expand_expr/expand_expr_real_1 with -msve-vector-bits=512 rguenth at gcc dot gnu.org
2020-03-17 12:59 ` [Bug target/94072] [10 Regression] ICE: SIGSEGV due to infinite recursion in expand_expr/expand_expr_real_1 with -msve-vector-bits=512 since r10-4197 jakub at gcc dot gnu.org
2020-03-17 13:43 ` rsandifo at gcc dot gnu.org
2020-03-20 16:15 ` cvs-commit at gcc dot gnu.org [this message]
2020-03-20 16:16 ` rsandifo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94072-4-CivMPCszcA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).