public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/94134] pdp11-aout puts initial variable into .text section rather than .data
Date: Wed, 11 Mar 2020 14:48:24 +0000	[thread overview]
Message-ID: <bug-94134-4-o1ObMHPpcq@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94134-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94134

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pkoning at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The generic code wants to emit this into lcomm_section:
1203      if (ADDR_SPACE_GENERIC_P (as)
1204          && !DECL_THREAD_LOCAL_P (decl)
1205          && !(prefer_noswitch_p && targetm.have_switchable_bss_sections)
1206          && bss_initializer_p (decl))
1207        {
1208          if (!TREE_PUBLIC (decl)
1209              && !((flag_sanitize & SANITIZE_ADDRESS)
1210                   && asan_protect_global (decl)))
1211            return lcomm_section;
1212          if (bss_noswitch_section)
1213            return bss_noswitch_section;
1214        }
which is a NOSWITCH section, see
https://gcc.gnu.org/ml/gcc-patches/2006-02/msg01857.html
pdp11 defines ASM_OUTPUT_ALIGNED_LOCAL to pdp11_asm_output_var (similarly for
ASM_OUTPUT_ALIGNED_COMMON), but as both are NOSWITCH sections, I think it is
wrong to emit it in whatever section is currently active.

  parent reply	other threads:[~2020-03-11 14:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  6:52 [Bug target/94134] New: " casner at acm dot org
2020-03-11  7:05 ` [Bug target/94134] " casner at acm dot org
2020-03-11  7:32 ` pinskia at gcc dot gnu.org
2020-03-11  7:34 ` pinskia at gcc dot gnu.org
2020-03-11  8:26 ` jakub at gcc dot gnu.org
2020-03-11 14:48 ` jakub at gcc dot gnu.org [this message]
2020-03-11 14:52 ` jakub at gcc dot gnu.org
2020-03-11 16:57 ` pkoning at gcc dot gnu.org
2020-03-11 17:37 ` jakub at gcc dot gnu.org
2020-03-11 20:14 ` casner at acm dot org
2020-03-11 20:19 ` casner at acm dot org
2020-03-11 21:10 ` pkoning at gcc dot gnu.org
2020-03-11 23:18 ` casner at acm dot org
2020-03-11 23:43 ` casner at acm dot org
2020-03-17 18:57 ` cvs-commit at gcc dot gnu.org
2020-09-17 14:24 ` cvs-commit at gcc dot gnu.org
2020-09-17 17:18 ` jakub at gcc dot gnu.org
2020-09-18  5:27 ` casner at acm dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94134-4-o1ObMHPpcq@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).