public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/94149] __is_constructible doesn't know about C++20 parenthesized init for arrays
Date: Fri, 10 Apr 2020 17:55:37 +0000	[thread overview]
Message-ID: <bug-94149-4-HGwjDFEmGA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94149-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94149

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:62c25d7adb1a5664982449dda0e7f9ca63cf4735

commit r10-7681-g62c25d7adb1a5664982449dda0e7f9ca63cf4735
Author: Marek Polacek <polacek@redhat.com>
Date:   Thu Apr 9 16:31:59 2020 -0400

    c++: make __is_constructible work with paren-init of aggrs [PR94149]

    In C++20 this is well-formed:

      using T = int[2];
      T t(1, 2);

    which means that std::is_constructible_v<int[2], int, int> should be true.
    But constructible_expr immediately returned the error_mark_node when it
    saw a list with more than one element.  To give accurate results in
    C++20, we have to try initializing the aggregate from a parenthesized list
of
    values.

    To not repeat the same mistake as in c++/93790, if there's only one
    element, I'm trying {} only when () didn't succeed.  is_constructible5.C
    verifies this.

    In paren-init24.C std::is_nothrow_constructible_v doesn't work due to
     error: invalid 'static_cast' from type 'int' to type 'int [1]'
    and
     error: functional cast to array type 'int [2]'

    This needs to be fixed in libstdc++.

            PR c++/94149
            * method.c (constructible_expr): In C++20, try using parenthesized
            initialization of aggregates to determine the result of
            __is_constructible.

            * g++.dg/cpp2a/paren-init24.C: New test.
            * g++.dg/cpp2a/paren-init25.C: New test.
            * g++.dg/ext/is_constructible5.C: New test.

  parent reply	other threads:[~2020-04-10 17:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 18:41 [Bug c++/94149] New: " redi at gcc dot gnu.org
2020-03-11 18:47 ` [Bug c++/94149] " redi at gcc dot gnu.org
2020-03-11 19:58 ` mpolacek at gcc dot gnu.org
2020-03-11 20:29 ` ville.voutilainen at gmail dot com
2020-04-09 21:03 ` mpolacek at gcc dot gnu.org
2020-04-10 17:55 ` cvs-commit at gcc dot gnu.org [this message]
2020-04-10 17:56 ` mpolacek at gcc dot gnu.org
2020-04-21 21:19 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94149-4-HGwjDFEmGA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).