public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/94242] filesystem::path::generic_string() only works with std::allocator Date: Fri, 07 Aug 2020 11:43:02 +0000 [thread overview] Message-ID: <bug-94242-4-4yMEp1ylxD@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94242-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94242 --- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-8 branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:39a5a04daa09c711caeb6aaff12f1d03406fe29f commit r8-10392-g39a5a04daa09c711caeb6aaff12f1d03406fe29f Author: Jonathan Wakely <jwakely@redhat.com> Date: Sat Mar 21 21:51:07 2020 +0000 libstdc++: Fix path::generic_string allocator handling (PR 94242) It's not possible to construct a path::string_type from an allocator of a different type. Create the correct specialization of basic_string, and adjust path::_S_str_convert to use a basic_string_view so that it is independent of the allocator type. PR libstdc++/94242 * include/bits/fs_path.h (path::_S_str_convert): Replace first parameter with basic_string_view so that strings with different allocators can be accepted. (path::generic_string<C,T,A>()): Use basic_string object that uses the right allocator type. * testsuite/27_io/filesystem/path/generic/94242.cc: New test. * testsuite/27_io/filesystem/path/generic/generic_string.cc: Improve test coverage. (cherry picked from commit 9fc985118d9f5014afc1caf32a411ee5803fba61)
next prev parent reply other threads:[~2020-08-07 11:43 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-20 21:09 [Bug libstdc++/94242] New: " redi at gcc dot gnu.org 2020-03-20 21:10 ` [Bug libstdc++/94242] " redi at gcc dot gnu.org 2020-03-21 22:05 ` cvs-commit at gcc dot gnu.org 2020-03-21 22:15 ` redi at gcc dot gnu.org 2020-08-07 10:40 ` cvs-commit at gcc dot gnu.org 2020-08-07 11:43 ` cvs-commit at gcc dot gnu.org [this message] 2020-08-07 11:43 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94242-4-4yMEp1ylxD@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).