public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tschwinge at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/94248] [amdgcn] Doesn't build with RTL checking
Date: Wed, 22 Apr 2020 09:47:31 +0000 [thread overview]
Message-ID: <bug-94248-4-8nzR68wFA4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94248-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94248
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed|2020-04-21 00:00:00 |2020-4-22
--- Comment #6 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Andrew Stubbs from comment #5)
> Yes, the REG_P can still ICE with the additional checking enabled.
So are you fine with me installing Jakub's patch?
(In reply to Thomas Schwinge from comment #4)
> Thus, again:
>
> (In reply to Thomas Schwinge from comment #2)
> > (In reply to Jakub Jelinek from comment #1)
> > > --- gcc/config/gcn/gcn.md.jj 2020-03-03 07:57:42.363827602 +0100
> > > +++ gcc/config/gcn/gcn.md 2020-03-21 15:37:45.337552515 +0100
> > > @@ -625,7 +625,7 @@ (define_insn_and_split "*mov<mode>_insn"
> > > rtx outhi = gen_highpart_mode (SImode, <MODE>mode, operands[0]);
> > >
> > > /* Ensure that overlapping registers aren't corrupted. */
> > > - if (REGNO (outlo) == REGNO (inhi))
> > > + if (reg_overlap_mentioned_p (outlo, inhi))
> > > {
> > > operands[0] = outhi;
> > > operands[1] = inhi;
> > > ought to fix this
> >
> > I've tested that one; no more ICE, and bit-identical code for all target
> > libraries, so I suppose this is good to commit (Andrew, Julian)? If
> > approving this patch, please respond with "Reviewed-by: NAME <EMAIL>" so
> > that your effort will be recorded in the commit log, see
> > <https://gcc.gnu.org/wiki/Reviewed-by>.
next prev parent reply other threads:[~2020-04-22 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 11:27 [Bug target/94248] New: " tschwinge at gcc dot gnu.org
2020-03-21 14:39 ` [Bug target/94248] " jakub at gcc dot gnu.org
2020-03-23 10:43 ` tschwinge at gcc dot gnu.org
2020-03-23 10:49 ` ams at gcc dot gnu.org
2020-04-21 12:59 ` tschwinge at gcc dot gnu.org
2020-04-21 13:14 ` ams at gcc dot gnu.org
2020-04-22 9:47 ` tschwinge at gcc dot gnu.org [this message]
2020-04-22 12:10 ` ams at gcc dot gnu.org
2020-04-29 7:58 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-94248-4-8nzR68wFA4@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).