From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 74FF8386F02B; Tue, 21 Apr 2020 12:59:41 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 74FF8386F02B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1587473981;
 bh=P7eUysSeGMpusKuvKrWVtAH3twbQGSatqYRruCMjkbk=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=Twhi/UAfs2oT+t4tdMrn1r1od9wX/3LJt/3GHfzqN1CHYkp/YFijUwavURXIZ9p9t
 ozSsQZEPNwUS6Aq9sMBIhWHfH5vjAQ+JXaH34uUDUBg3JZjf9OWa3Wdi2KJLeSj6Kj
 H0uGf8GpFxrmrP0W3/3XL2W2bKO4tNOn3y8c8vOk=
From: "tschwinge at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/94248] [amdgcn] Doesn't build with RTL checking
Date: Tue, 21 Apr 2020 12:59:41 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: ice-checking, patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tschwinge at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cf_reconfirmed_on keywords
Message-ID: <bug-94248-4-RetPwukmM1@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94248-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94248-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2020 12:59:41 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94248

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2020-03-21 00:00:00         |2020-4-21
           Keywords|                            |patch

--- Comment #4 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Andrew Stubbs from comment #3)
> Actually, I think that recent changes to the register alignment mean that
> this can't happen any more, so the whole check is probably obsolete.

I don't know exactly what "this" and "the whole check" relate to, but I do
reconfirm that without Jakub's 'reg_overlap_mentioned_p' patch, I'm still
running into the ICE.


> I thought that --enable-checking=3Dyes was already covering this. :-(

Nope.  :-|


Thus, again:

(In reply to Thomas Schwinge from comment #2)
> (In reply to Jakub Jelinek from comment #1)
> > --- gcc/config/gcn/gcn.md.jj	2020-03-03 07:57:42.363827602 +0100
> > +++ gcc/config/gcn/gcn.md	2020-03-21 15:37:45.337552515 +0100
> > @@ -625,7 +625,7 @@ (define_insn_and_split "*mov<mode>_insn"
> >      rtx outhi =3D gen_highpart_mode (SImode, <MODE>mode, operands[0]);
> >=20=20
> >      /* Ensure that overlapping registers aren't corrupted.  */
> > -    if (REGNO (outlo) =3D=3D REGNO (inhi))
> > +    if (reg_overlap_mentioned_p (outlo, inhi))
> >        {
> >  	operands[0] =3D outhi;
> >  	operands[1] =3D inhi;
> > ought to fix this
>=20
> I've tested that one; no more ICE, and bit-identical code for all target
> libraries, so I suppose this is good to commit (Andrew, Julian)?  If
> approving this patch, please respond with "Reviewed-by: NAME <EMAIL>" so
> that your effort will be recorded in the commit log, see
> <https://gcc.gnu.org/wiki/Reviewed-by>.=