public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/94248] [amdgcn] Doesn't build with RTL checking Date: Sat, 21 Mar 2020 14:39:56 +0000 [thread overview] Message-ID: <bug-94248-4-fbf3Um4NDc@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94248-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94248 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org Ever confirmed|0 |1 Last reconfirmed| |2020-03-21 Status|UNCONFIRMED |NEW --- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Either: --- gcc/config/gcn/gcn.md.jj 2020-03-03 07:57:42.363827602 +0100 +++ gcc/config/gcn/gcn.md 2020-03-21 15:35:22.395639196 +0100 @@ -625,7 +625,7 @@ (define_insn_and_split "*mov<mode>_insn" rtx outhi = gen_highpart_mode (SImode, <MODE>mode, operands[0]); /* Ensure that overlapping registers aren't corrupted. */ - if (REGNO (outlo) == REGNO (inhi)) + if (REG_P (inhi) && REGNO (outlo) == REGNO (inhi)) { operands[0] = outhi; operands[1] = inhi; or: --- gcc/config/gcn/gcn.md.jj 2020-03-03 07:57:42.363827602 +0100 +++ gcc/config/gcn/gcn.md 2020-03-21 15:37:45.337552515 +0100 @@ -625,7 +625,7 @@ (define_insn_and_split "*mov<mode>_insn" rtx outhi = gen_highpart_mode (SImode, <MODE>mode, operands[0]); /* Ensure that overlapping registers aren't corrupted. */ - if (REGNO (outlo) == REGNO (inhi)) + if (reg_overlap_mentioned_p (outlo, inhi)) { operands[0] = outhi; operands[1] = inhi; ought to fix this, but I don't yet have setup where I can sufficiently test it. I think the latter is better and is in line what other backends are using.
next prev parent reply other threads:[~2020-03-21 14:39 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-21 11:27 [Bug target/94248] New: " tschwinge at gcc dot gnu.org 2020-03-21 14:39 ` jakub at gcc dot gnu.org [this message] 2020-03-23 10:43 ` [Bug target/94248] " tschwinge at gcc dot gnu.org 2020-03-23 10:49 ` ams at gcc dot gnu.org 2020-04-21 12:59 ` tschwinge at gcc dot gnu.org 2020-04-21 13:14 ` ams at gcc dot gnu.org 2020-04-22 9:47 ` tschwinge at gcc dot gnu.org 2020-04-22 12:10 ` ams at gcc dot gnu.org 2020-04-29 7:58 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94248-4-fbf3Um4NDc@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).