public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "xerofoify at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/94250] valgrind error for ./g++.dg/ipa/remref-1.C
Date: Sat, 21 Mar 2020 15:20:48 +0000	[thread overview]
Message-ID: <bug-94250-4-73T4s0UGaG@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94250-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94250

--- Comment #2 from Nicholas Krause <xerofoify at gmail dot com> ---
(In reply to Nicholas Krause from comment #1)
> After looking through the git history that last time this functions in your
> trace were changed is by commit id,
> db30281f0b2ff6dfc0c4146291baf020a27e4065. Martin Liska  was the original
> committer so he should comment on this.
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;
> h=db30281f0b2ff6dfc0c4146291baf020a27e4065
> 
> However this was changed:
> summary->duplicate (edge1, edge2, edge1_summary,
>                   summary->get_create (edge2));

and it appears to be assuming based on the above lines:
if (summary->m_initialize_when_cloning)
 edge1_summary = summary->get_create (edge1);
else
 edge1_summary = summary->get (edge1);

That this can never occur for edge2. Martin is edge2 assumed to be good by this
comment?

  parent reply	other threads:[~2020-03-21 15:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21 14:31 [Bug c++/94250] New: " dcb314 at hotmail dot com
2020-03-21 15:15 ` [Bug c++/94250] " xerofoify at gmail dot com
2020-03-21 15:20 ` xerofoify at gmail dot com [this message]
2020-03-21 17:32 ` marxin at gcc dot gnu.org
2020-03-21 17:36 ` [Bug ipa/94250] [10 Regression] ]valgrind " marxin at gcc dot gnu.org
2020-03-21 17:44 ` [Bug ipa/94250] [10 Regression] valgrind " dcb314 at hotmail dot com
2020-03-21 17:46 ` marxin at gcc dot gnu.org
2020-03-23  7:57 ` cvs-commit at gcc dot gnu.org
2020-03-23  7:58 ` marxin at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94250-4-73T4s0UGaG@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).