public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94269] widening_mul should consider block frequency
Date: Thu, 26 Mar 2020 07:36:59 +0000	[thread overview]
Message-ID: <bug-94269-4-DjQPujwNOB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94269-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94269

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:d21dff5b4fee51ae432143065bededfc763dc344

commit r10-7391-gd21dff5b4fee51ae432143065bededfc763dc344
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Mar 26 08:33:57 2020 +0100

    widening_mul: restrict ops to be defined in the same basic-block when
convert plusminus to widen

    In the testcase for PR94269, widening_mul moves two multiply
    instructions from outside the loop to inside
    the loop, merging with two add instructions separately.  This
    increases the cost of the loop.  Like FMA detection
    in the same pass, simply restrict ops to be defined in the same
    basic-block to avoid possibly moving multiply
    to a different block with a higher execution frequency.

    2020-03-26  Felix Yang  <felix.yang@huawei.com>

            PR tree-optimization/94269
            * tree-ssa-math-opts.c (convert_plusminus_to_widen): Restrict
            this
            operation to single basic block.

            * gcc.dg/pr94269.c: New test.

      parent reply	other threads:[~2020-03-26  7:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23  9:47 [Bug tree-optimization/94269] New: " felix.yang at huawei dot com
2020-03-23 14:14 ` [Bug tree-optimization/94269] " rguenth at gcc dot gnu.org
2020-03-26  7:36 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94269-4-DjQPujwNOB@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).