[Bug debug/94283] New: [8/9/10 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[Bug debug/94283] New: [8/9/10 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

            Bug ID: 94283
           Summary: [8/9/10 Regression] gcc: error:
                    gcc/testsuite/gcc.dg/fold-bopcond-1.c:
                    ‘-fcompare-debug’ failure since
                    r7-4804-gb54819879e0518b3
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: amker at gcc dot gnu.org
  Target Milestone: ---

The following fails:

$ gcc /home/marxin/Programming/gcc/gcc/testsuite/gcc.dg/fold-bopcond-1.c -mavx2
-O3 -fcompare-debug -c
gcc: error: /home/marxin/Programming/gcc/gcc/testsuite/gcc.dg/fold-bopcond-1.c:
‘-fcompare-debug’ failure

[Bug debug/94283] [8/9/10 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-03-23
           Priority|P3                          |P2

[Bug debug/94283] [8/9/10 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.5

[Bug debug/94283] [8/9/10 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Latent since r5-6439-ge9d5a1a001f798a90fe6fcb031138740ce6ffb36.

[Bug debug/94283] [8/9/10 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 48094
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48094&action=edit
gcc10-pr94283.patch

Untested fix.

[Bug debug/94283] [8/9/10 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:a5a9400a846244d040caa6d1531434eee8fc8ec7

commit r10-7350-ga5a9400a846244d040caa6d1531434eee8fc8ec7
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 24 09:34:58 2020 +0100

    if-conv: Fix -fcompare-debug bugs in ifcvt_local_dce [PR94283]

    The following testcase shows -fcompare-debug bugs in ifcvt_local_dce,
    where the decisions what statements are needed is based also on debug stmt
    operands, which is wrong.
    So, this patch makes sure to never add debug stmt to the worklist, or never
    add an assign to worklist just because it is used in a debug stmt in
another
    bb.

    2020-03-24  Jakub Jelinek  <jakub@redhat.com>

            PR debug/94283
            * tree-if-conv.c (ifcvt_local_dce): For gimple debug stmts, just
set
            GF_PLF_2, but don't add them to worklist.  Don't add an assigment
to
            worklist or set GF_PLF_2 just because it is used in a debug stmt in
            another bb.  Formatting improvements.

            * gcc.target/i386/pr94283.c: New test.

[Bug debug/94283] [8/9 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9/10 Regression] gcc:    |[8/9 Regression] gcc:
                   |error:                      |error:
                   |gcc/testsuite/gcc.dg/fold-b |gcc/testsuite/gcc.dg/fold-b
                   |opcond-1.c:                 |opcond-1.c:
                   |‘-fcompare-debug’ failure   |‘-fcompare-debug’ failure
                   |since                       |since
                   |r7-4804-gb54819879e0518b3   |r7-4804-gb54819879e0518b3

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug debug/94283] [8/9 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

--- Comment #5 from Jeffrey A. Law <law at redhat dot com> ---
*** Bug 94284 has been marked as a duplicate of this bug. ***

[Bug debug/94283] [8/9 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:c2133167ad58d15c2c2df0cb4fa3a3757603144e

commit r10-7365-gc2133167ad58d15c2c2df0cb4fa3a3757603144e
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Mar 25 08:08:04 2020 +0100

    if-conv: Delete dead stmts backwards in ifcvt_local_dce [PR94283]

    > > This patch caused:
    > >
    > > gcc
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/990625-2.c -O3
-g -fno-tree-dce -c
    > > during GIMPLE pass: ifcvt
    > >
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/990625-2.c: In
function âbroken030599â:
    > >
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/990625-2.c:2:1:
internal compiler error: Segmentation fault
    >
    > Likely
    >
    >   /* Delete dead statements.  */
    >   gsi = gsi_start_bb (bb);
    >   while (!gsi_end_p (gsi))
    >     {
    >
    > needs to instead work back-to-front for debug stmt adjustment to work

    Indeed, that seems to work.

    2020-03-25  Richard Biener  <rguenther@suse.de>
                Jakub Jelinek  <jakub@redhat.com>

            PR debug/94283
            * tree-if-conv.c (ifcvt_local_dce): Delete dead statements
backwards.

            * gcc.dg/pr94283.c: New test.

    Co-authored-by: Richard Biener <rguenther@suse.de>

[Bug debug/94283] [8/9 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4dcfd4e56b0d22af12750372f3e0b49249b1d473

commit r9-8469-g4dcfd4e56b0d22af12750372f3e0b49249b1d473
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 7 20:57:37 2020 +0200

    if-conv: Fix -fcompare-debug bugs in ifcvt_local_dce [PR94283]

    The following testcase shows -fcompare-debug bugs in ifcvt_local_dce,
    where the decisions what statements are needed is based also on debug stmt
    operands, which is wrong.
    So, this patch makes sure to never add debug stmt to the worklist, or never
    add an assign to worklist just because it is used in a debug stmt in
another
    bb.

    2020-03-24  Jakub Jelinek  <jakub@redhat.com>

            PR debug/94283
            * tree-if-conv.c (ifcvt_local_dce): For gimple debug stmts, just
set
            GF_PLF_2, but don't add them to worklist.  Don't add an assigment
to
            worklist or set GF_PLF_2 just because it is used in a debug stmt in
            another bb.  Formatting improvements.

            * gcc.target/i386/pr94283.c: New test.

[Bug debug/94283] [8/9 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:8ea7970c4968517fb73f42bcca40d316adacf215

commit r9-8470-g8ea7970c4968517fb73f42bcca40d316adacf215
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Mar 25 08:08:04 2020 +0100

    if-conv: Delete dead stmts backwards in ifcvt_local_dce [PR94283]

    > > This patch caused:
    > >
    > > gcc
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/990625-2.c -O3
-g -fno-tree-dce -c
    > > during GIMPLE pass: ifcvt
    > >
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/990625-2.c: In
function âbroken030599â:
    > >
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/990625-2.c:2:1:
internal compiler error: Segmentation fault
    >
    > Likely
    >
    >   /* Delete dead statements.  */
    >   gsi = gsi_start_bb (bb);
    >   while (!gsi_end_p (gsi))
    >     {
    >
    > needs to instead work back-to-front for debug stmt adjustment to work

    Indeed, that seems to work.

    2020-03-25  Richard Biener  <rguenther@suse.de>
                Jakub Jelinek  <jakub@redhat.com>

            PR debug/94283
            * tree-if-conv.c (ifcvt_local_dce): Delete dead statements
backwards.

            * gcc.dg/pr94283.c: New test.

    Co-authored-by: Richard Biener <rguenther@suse.de>

[Bug debug/94283] [8 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9 Regression] gcc:       |[8 Regression] gcc: error:
                   |error:                      |gcc/testsuite/gcc.dg/fold-b
                   |gcc/testsuite/gcc.dg/fold-b |opcond-1.c:
                   |opcond-1.c:                 |‘-fcompare-debug’ failure
                   |‘-fcompare-debug’ failure   |since
                   |since                       |r7-4804-gb54819879e0518b3
                   |r7-4804-gb54819879e0518b3   |

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 9.4+ too.

[Bug debug/94283] [8 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:c9790fa67882765eb293774e629cd071de857952

commit r8-10473-gc9790fa67882765eb293774e629cd071de857952
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 7 20:57:37 2020 +0200

    if-conv: Fix -fcompare-debug bugs in ifcvt_local_dce [PR94283]

    The following testcase shows -fcompare-debug bugs in ifcvt_local_dce,
    where the decisions what statements are needed is based also on debug stmt
    operands, which is wrong.
    So, this patch makes sure to never add debug stmt to the worklist, or never
    add an assign to worklist just because it is used in a debug stmt in
another
    bb.

    2020-03-24  Jakub Jelinek  <jakub@redhat.com>

            PR debug/94283
            * tree-if-conv.c (ifcvt_local_dce): For gimple debug stmts, just
set
            GF_PLF_2, but don't add them to worklist.  Don't add an assigment
to
            worklist or set GF_PLF_2 just because it is used in a debug stmt in
            another bb.  Formatting improvements.

            * gcc.target/i386/pr94283.c: New test.

    (cherry picked from commit 4dcfd4e56b0d22af12750372f3e0b49249b1d473)

[Bug debug/94283] [8 Regression] gcc: error: gcc/testsuite/gcc.dg/fold-bopcond-1.c: ‘-fcompare-debug’ failure since r7-4804-gb54819879e0518b3

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94283

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 8.5 too.