From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id EB6C4385E017; Thu, 26 Mar 2020 09:50:04 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB6C4385E017
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1585216204;
 bh=eeOAvL/8SntZhxN3IJo9VQ8+fucHZ9JTXQyFwSw4K74=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=doLVaXMfPMFyJ4zNCWNrUheeQpePRUUUU60kr/Wtk1RzG6KwVVOTylTEN8Uypwdpm
 HhhKTO71PITW/vnAkwSqER/JUeop42hrYuMm7wQtzw3UTEbkZHHk7gAcq3pdCsYbAq
 s2XMPUmcyzPTjhKxdRob4wjA0Gz0UQrGLVX2lXTk=
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: =?UTF-8?B?W0J1ZyBsdG8vOTQzMjBdIFtPcGVuTVBdW09mZmxvYWRpbmddIGx0?=
 =?UTF-8?B?bzEgSUNFIGR1cmluZyBJUEEgcGFzczogaW5saW5lIOKAkyBvZmZsaW5lX3Np?=
 =?UTF-8?B?emUgYXQgZ2NjL2lwYS1pbmxpbmUtYW5hbHlzaXMuYzo0NTM=?=
Date: Thu, 26 Mar 2020 09:50:04 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: ice-on-valid-code, openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: burnus at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-94320-4-cTKR0Wnnvw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94320-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94320-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <http://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2020 09:50:05 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94320

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #1)
> tried
> +      && !lto_stream_offload_p

With that patch, I get 6 times "has been referenced in offloaded code but
hasn't been marked to be included in the offloaded code".

Thus, that's a useful patch for the code I looked at. All those those funct=
ions
are template functions. (With -O0, the nvptx run-time compilers complains o=
nly
about 3 of those functions.)

> I'm afraid we need to actually implement properly the OpenMP 5.0
> automatic omp declare target discovery

Yes, it looks like that. I think C++ code is mostly affected as one quickly
ends up using 'operator[]' and similar functions, which are not always inli=
ned.

Additionally, template programming makes it harder for the user to mark tho=
se
functions as 'declare target'.=