public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/94330] New: No warning if jobserver not available
@ 2020-03-25 15:34 rdiezmail-gcc at yahoo dot de
  2020-03-26  6:55 ` [Bug driver/94330] " rguenth at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: rdiezmail-gcc at yahoo dot de @ 2020-03-25 15:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94330

            Bug ID: 94330
           Summary: No warning if jobserver not available
           Product: gcc
           Version: 8.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rdiezmail-gcc at yahoo dot de
  Target Milestone: ---

If you pass -flto=jobserver , and the jobserver file descriptors are not
actually available, you get no warning whatsoever from GCC.

GNU Make does try to help in this scenario with the following warning:

make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make
rule.

Without such a warning, it is really easy to miss the opportunity to
parallelise the build. In fact, GCC seems to use 2 threads in this scenario,
which misleads you into thinking that the option is working correctly, when in
fact is not using all other CPU cores.

More context on this issue is here:

https://lists.gnu.org/archive/html/help-make/2020-02/msg00000.html

https://gcc.gnu.org/legacy-ml/gcc-help/2020-02/msg00069.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/94330] No warning if jobserver not available
  2020-03-25 15:34 [Bug other/94330] New: No warning if jobserver not available rdiezmail-gcc at yahoo dot de
@ 2020-03-26  6:55 ` rguenth at gcc dot gnu.org
  2020-03-26  9:00 ` marxin at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-03-26  6:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94330

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|other                       |driver
           Keywords|                            |lto
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-03-26

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/94330] No warning if jobserver not available
  2020-03-25 15:34 [Bug other/94330] New: No warning if jobserver not available rdiezmail-gcc at yahoo dot de
  2020-03-26  6:55 ` [Bug driver/94330] " rguenth at gcc dot gnu.org
@ 2020-03-26  9:00 ` marxin at gcc dot gnu.org
  2020-03-26  9:41 ` marxin at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-26  9:00 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94330

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
I've got patch for it.
@Richi: Is it stage1 material or can we add it for GCC 10?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/94330] No warning if jobserver not available
  2020-03-25 15:34 [Bug other/94330] New: No warning if jobserver not available rdiezmail-gcc at yahoo dot de
  2020-03-26  6:55 ` [Bug driver/94330] " rguenth at gcc dot gnu.org
  2020-03-26  9:00 ` marxin at gcc dot gnu.org
@ 2020-03-26  9:41 ` marxin at gcc dot gnu.org
  2020-05-05 14:11 ` cvs-commit at gcc dot gnu.org
  2020-05-05 14:13 ` marxin at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-03-26  9:41 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94330

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2020-March/5
                   |                            |42715.html
           Keywords|                            |patch
   Target Milestone|---                         |11.0

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
I'm just sent the patch to the mailing list.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/94330] No warning if jobserver not available
  2020-03-25 15:34 [Bug other/94330] New: No warning if jobserver not available rdiezmail-gcc at yahoo dot de
                   ` (2 preceding siblings ...)
  2020-03-26  9:41 ` marxin at gcc dot gnu.org
@ 2020-05-05 14:11 ` cvs-commit at gcc dot gnu.org
  2020-05-05 14:13 ` marxin at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-05 14:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94330

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:0f62caf58b5d11f375f789385d6d49891ebd9a94

commit r11-81-g0f62caf58b5d11f375f789385d6d49891ebd9a94
Author: Martin Liska <mliska@suse.cz>
Date:   Tue May 5 16:11:33 2020 +0200

    Provide warning for missing jobserver.

            PR driver/94330
            * lto-wrapper.c (run_gcc): When using -flto=jobserver,
            report warning when the jobserver is not detected.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/94330] No warning if jobserver not available
  2020-03-25 15:34 [Bug other/94330] New: No warning if jobserver not available rdiezmail-gcc at yahoo dot de
                   ` (3 preceding siblings ...)
  2020-05-05 14:11 ` cvs-commit at gcc dot gnu.org
@ 2020-05-05 14:13 ` marxin at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-05-05 14:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94330

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed on master.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-05-05 14:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 15:34 [Bug other/94330] New: No warning if jobserver not available rdiezmail-gcc at yahoo dot de
2020-03-26  6:55 ` [Bug driver/94330] " rguenth at gcc dot gnu.org
2020-03-26  9:00 ` marxin at gcc dot gnu.org
2020-03-26  9:41 ` marxin at gcc dot gnu.org
2020-05-05 14:11 ` cvs-commit at gcc dot gnu.org
2020-05-05 14:13 ` marxin at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).