public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/94343] [10 Regression] invalid AVX512VL vpternlogd instruction emitted for -march=knl Date: Thu, 26 Mar 2020 16:41:11 +0000 [thread overview] Message-ID: <bug-94343-4-dqKLcBfNlF@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94343-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94343 --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- I was thinking about --- gcc/config/i386/sse.md.jj 2020-03-06 11:35:46.284074858 +0100 +++ gcc/config/i386/sse.md 2020-03-26 17:35:23.690515228 +0100 @@ -12800,10 +12800,18 @@ (xor:VI (match_operand:VI 1 "nonimmediate_operand" "vm") (match_operand:VI 2 "vector_all_ones_operand" "BC")))] "TARGET_AVX512F" - "vpternlog<ternlogsuffix>\t{$0x55, %1, %0, %0<mask_operand3>|%0<mask_operand3>, %0, %1, 0x55}" +{ + if (TARGET_AVX512VL) + return "vpternlog<ternlogsuffix>\t{$0x55, %1, %0, %0<mask_operand3>|%0<mask_operand3>, %0, %1, 0x55}"; + else + return "vpternlog<ternlogsuffix>\t{$0x55, %g1, %g0, %g0<mask_operand3>|%g0<mask_operand3>, %g0, %g1, 0x55}"; +} [(set_attr "type" "sselog") (set_attr "prefix" "evex") - (set_attr "mode" "<sseinsnmode>")]) + (set (attr "mode") + (if_then_else (match_test "TARGET_AVX512VL") + (const_string "<sseinsnmode>") + (const_string "XI")))]) (define_expand "<sse2_avx2>_andnot<mode>3" [(set (match_operand:VI_AVX2 0 "register_operand") instead. I'm aware that from performance POV we are trying to avoid 512-bit vectors, but don't all such affected CPUs support AVX512VL already? Does KNL care if it will do a 512-bit operation instead of 128-bit or 256-bit?
next prev parent reply other threads:[~2020-03-26 16:41 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-26 15:24 [Bug target/94343] New: " kretz at kde dot org 2020-03-26 15:39 ` [Bug target/94343] " marxin at gcc dot gnu.org 2020-03-26 15:58 ` jakub at gcc dot gnu.org 2020-03-26 16:34 ` hjl.tools at gmail dot com 2020-03-26 16:41 ` jakub at gcc dot gnu.org [this message] 2020-03-26 17:08 ` jakub at gcc dot gnu.org 2020-03-26 17:14 ` hjl.tools at gmail dot com 2020-03-26 17:52 ` jakub at gcc dot gnu.org 2020-03-26 17:59 ` jakub at gcc dot gnu.org 2020-03-26 19:30 ` kretz at kde dot org 2020-03-26 19:44 ` jakub at gcc dot gnu.org 2020-03-27 7:00 ` jbeulich at suse dot com 2020-03-27 7:07 ` jbeulich at suse dot com 2020-03-27 7:31 ` jbeulich at suse dot com 2020-03-27 8:45 ` jakub at gcc dot gnu.org 2020-03-27 9:11 ` jakub at gcc dot gnu.org 2020-03-27 9:17 ` jbeulich at suse dot com 2020-03-27 9:21 ` jakub at gcc dot gnu.org 2020-03-30 16:05 ` cvs-commit at gcc dot gnu.org 2020-03-30 16:06 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94343-4-dqKLcBfNlF@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).