From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id B2008385DC2D; Tue, 14 Apr 2020 19:44:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2008385DC2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1586893489; bh=IJ3/PApt1IvdilgaXHW8H6PSgU3/46TML9rsMe+B5N8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=jVmuPW7BX1vHMr33JUiGyhlW1nfPLvd4VbuytXHEyNYweZTnypXyjm5kSW76HVBMz UdcHmJCFKUxVA19hXgQqJXREA8fg4g6PDNhtXlK13FNng7H4NQm/iAzpVIrD2sx4Zp PzCc4H/AKXBwLSOd9UQarGLRfIur5yFt1xXj3qQ0= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/94359] new test case g++.dg/coroutines/torture/symmetric-transfer-00-basic.C fails Date: Tue, 14 Apr 2020 19:44:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c++ X-Bugzilla-Version: 10.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: iains at gcc dot gnu.org X-Bugzilla-Target-Milestone: 10.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 19:44:49 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94359 --- Comment #13 from CVS Commits --- The master branch has been updated by Iain D Sandoe : https://gcc.gnu.org/g:a126a1577ffcbf62d97723b35d343bdff014bb40 commit r10-7724-ga126a1577ffcbf62d97723b35d343bdff014bb40 Author: Iain Sandoe Date: Tue Apr 14 20:37:12 2020 +0100 coroutines: Fix compile error with symmetric transfers [PR94359] For symmetric transfers to work with C++20 coroutines, it is currently necessary to tail call the callee coroutine from resume method of the caller coroutine. The current codegen marks these resume calls as "MUST_TAIL_CALL" to indicate that the tail call is required for correctness. Unfortunately, several targets have ABI constraints that prevent an indirect tail-call, which results in the PRs compile error. The change here tests the target sibcall hook for the resume expression and only marks it as requiring a tail call if that's supported. This doesn't fix the underlying problem; that really a solution is needed to allow the tail-calls (or equivalent) to take place - but that will be deferred until next stage 1. gcc/cp/ChangeLog: 2020-04-14 Iain Sandoe PR c++/94359 * coroutines.cc (build_actor_fn): Check that the target can support the resume tailcall before mandating it. gcc/testsuite/ChangeLog: 2020-04-14 Iain Sandoe PR c++/94359 * g++.dg/coroutines/torture/symmetric-transfer-00-basic.C: Expect a run fail for targets without arbitrary indirect tail-calls.=