From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B5DDD3857018; Wed, 11 May 2022 06:21:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5DDD3857018
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/94366] OpenMP Parallel Reduction with "&&" operator
 does not compute correct result
Date: Wed, 11 May 2022 06:21:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 9.3.0
X-Bugzilla-Keywords: openmp, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-94366-4-xhH7PahUqY@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-94366-4@http.gcc.gnu.org/bugzilla/>
References: <bug-94366-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2022 06:21:35 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D94366

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:26c58b164fd78db4ce25f0183ed0225c08018f3f

commit r9-10091-g26c58b164fd78db4ce25f0183ed0225c08018f3f
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jul 1 08:55:49 2021 +0200

    openmp - Fix up && and || reductions [PR94366]

    As the testcase shows, the special treatment of && and || reduction
combiners
    where we expand them as omp_out =3D (omp_out !=3D 0) && (omp_in !=3D 0)=
 (or with
||)
    is not needed just for &&/|| on floating point or complex types, but for
all
    &&/|| reductions - when expanded as omp_out =3D omp_out && omp_in (not =
in C
but
    GENERIC) it is actually gimplified into NOP_EXPRs to bool from both
operands,
    which turns non-zero values multiple of 2 into 0 rather than 1.

    This patch just treats all &&/|| the same and furthermore uses bool type
    instead of int for the comparisons.

    2021-07-01  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/94366
    gcc/
            * omp-low.c (lower_rec_input_clauses): Rename is_fp_and_or to
            is_truth_op, set it for TRUTH_*IF_EXPR regardless of new_var's
type,
            use boolean_type_node instead of integer_type_node as NE_EXPR t=
ype.
            (lower_reduction_clauses): Likewise.
    libgomp/
            * testsuite/libgomp.c-c++-common/pr94366.c: New test.

    (cherry picked from commit 91c771ec8a3b649765de3e0a7b04cf946c6649ef)=