[Bug target/94372] New: pthread doesn't define _REENTRANT in preprocessor on OpenRISC

[Bug target/94372] New: pthread doesn't define _REENTRANT in preprocessor on OpenRISC

[bernd.kuhls@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94372

            Bug ID: 94372
           Summary: pthread doesn't define _REENTRANT in preprocessor on
                    OpenRISC
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bernd.kuhls@t-online.de
  Target Milestone: ---

Created attachment 48138
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48138&action=edit
Patch

OpenRISC doesn't have _REENTRANT defined when -pthread is appended.

Some software, like libmicrohttpd, check in their configure script if
_REENTRANT is correctly defined as seen on buildroot autobuilders:
http://autobuild.buildroot.net/results/ceb802eea0fee5812efd717ae4cdbd9673d9507e/libmicrohttpd-0.9.70/config.log

This bug is similar to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84475

[Bug target/94372] pthread doesn't define _REENTRANT in preprocessor on OpenRISC

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94372

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2020-03-28
     Ever confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Setting component=target without populating the "Target" field is meaningless,
please add the output of 'gcc -dumpmachine' to the Target field.

[Bug target/94372] pthread doesn't define _REENTRANT in preprocessor on OpenRISC

[shorne at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94372

Stafford Horne <shorne at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |ASSIGNED

--- Comment #2 from Stafford Horne <shorne at gcc dot gnu.org> ---
The patch looks fine, I missed it as it seems the patch was only posted in
bugzilla.  Usually sending a patch to gcc-patches will get more attention.

[Bug target/94372] pthread doesn't define _REENTRANT in preprocessor on OpenRISC

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94372

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Stafford Horne <shorne@gcc.gnu.org>:

https://gcc.gnu.org/g:cac2f69cdad434ad5cb60f5fe931d45cd82ef476

commit r12-6996-gcac2f69cdad434ad5cb60f5fe931d45cd82ef476
Author: Bernd Kuhls <bernd.kuhls@t-online.de>
Date:   Fri Mar 27 21:23:53 2020 +0100

    gcc: define _REENTRANT for OpenRISC when -pthread is passed

    The detection of pthread support fails on OpenRISC unless _REENTRANT
    is defined. Added the CPP_SPEC definition to correct this.

    gcc/ChangeLog:

            PR target/94372
            * config/or1k/linux.h (CPP_SPEC): Define.

    Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

[Bug target/94372] pthread doesn't define _REENTRANT in preprocessor on OpenRISC

[shorne at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94372

Stafford Horne <shorne at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Stafford Horne <shorne at gcc dot gnu.org> ---
Patch applied. Thank you