[Bug c++/94437] New: Internal compiler error in avr-g++

[Bug c++/94437] New: Internal compiler error in avr-g++

[gatk555 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

            Bug ID: 94437
           Summary: Internal compiler error in avr-g++
           Product: gcc
           Version: 7.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gatk555 at gmail dot com
  Target Milestone: ---

Created attachment 48158
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48158&action=edit
Source code

Attempting to compile the attached C++ file (BUG.cpp) produces a report of an
internal error:

BUG.cpp: In function 'int fetch_byte(FVM::code_P)':
BUG.cpp:16:31: internal compiler error: in type_hash_canon, at tree.c:7158
   if (ip < (FVM::code_P) FVM::CODE_P_MAX)
                               ^~~~~~~~~~
Please submit a full bug report,
with preprocessed source if appropriate.

Attachments:
BUG.cpp: source code, not a *.ii as the source is self-contained.
output: stdout/err output from compilation and "g++-avr -v"
bug: short script of commands to produce "output"

This is the compiler binary included with the Arduino IDE version 1.8.12.
I believe it is standard as the Arduino website does tell you when they have
modified source code of other components.

Environment: Debian GNU/Linux version 10.
Linux oldell 4.19.0-8-amd64 #1 SMP Debian 4.19.98-1 (2020-01-26) x86_64
GNU/Linux

[Bug c++/94437] Internal compiler error in avr-g++

[gatk555 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

--- Comment #1 from Giles Atkinson <gatk555 at gmail dot com> ---
Created attachment 48159
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48159&action=edit
Compiler commands

[Bug c++/94437] Internal compiler error in avr-g++

[gatk555 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

--- Comment #2 from Giles Atkinson <gatk555 at gmail dot com> ---
Created attachment 48160
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48160&action=edit
Compiler output

[Bug c++/94437] Internal compiler error in avr-g++

[gatk555 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

--- Comment #3 from Giles Atkinson <gatk555 at gmail dot com> ---
Bug goes away when the __attribute__ is removed (which also makes the code
pointless!)

[Bug target/94437] Internal compiler error in avr-g++

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c++                         |target
             Target|                            |Avr

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
GCC 7.x is no longer supported, can you try gcc 8.5.0 or 9.3.0 (or later)?

[Bug target/94437] Internal compiler error in avr-g++

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING
                 CC|                            |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2020-04-01

[Bug target/94437] Internal compiler error in avr-g++

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed on trunk.

7157      loc = type_hash_table->find_slot_with_hash (&in, hashcode, INSERT);
7158      if (*loc)
7159        {
7160          tree t1 = ((type_hash *) *loc)->type;
7161          gcc_assert (TYPE_MAIN_VARIANT (t1) == t1
7162                      && t1 != type);

so it looks like the target specific attribute handler wrecks things here.

The code does


static tree
avr_handle_progmem_attribute (tree *node, tree name,
                              tree args ATTRIBUTE_UNUSED,
                              int flags ATTRIBUTE_UNUSED,
                              bool *no_add_attrs)
{
...
          tree newtype = build_type_attribute_variant (type, attr);

          TYPE_MAIN_VARIANT (newtype) = TYPE_MAIN_VARIANT (type);

but built_type_attribute_variant builds a distinct copy and inserts it
into the hash, expecting only main variants to be present there.  The
above assignment breaks that assumption.

[Bug target/94437] Internal compiler error in avr-g++

[gatk555 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

Giles Atkinson <gatk555 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |9.3.0

--- Comment #6 from Giles Atkinson <gatk555 at gmail dot com> ---
Also confirmed in 9.3.0.  I only just saw Comment #5, as I was busy building
the newer compiler!

ga@oldell:~/gcc/avr/bin$ ./avr-g++ -c
~/Arduino/sketches/libraries/BUG/src/BUG.cpp
/home/ga/Arduino/sketches/libraries/BUG/src/BUG.cpp: In function ‘int
fetch_byte(FVM::code_P)’:
/home/ga/Arduino/sketches/libraries/BUG/src/BUG.cpp:16:31: internal compiler
error: in type_hash_canon, at tree.c:7072
   16 |   if (ip < (FVM::code_P) FVM::CODE_P_MAX)
      |                               ^~~~~~~~~~
0x58bbe3 type_hash_canon(unsigned int, tree_node*)
        ../../gcc-9.3.0/gcc/tree.c:7071
0x6f53da build_type_attribute_qual_variant(tree_node*, tree_node*, int)
        ../../gcc-9.3.0/gcc/attribs.c:1157
0x6f53da build_type_attribute_qual_variant(tree_node*, tree_node*, int)
        ../../gcc-9.3.0/gcc/attribs.c:1122
0x6e308f cp_build_binary_op(op_location_t const&, tree_code, tree_node*,
tree_node*, int)
        ../../gcc-9.3.0/gcc/cp/typeck.c:5233
0x5ac4b6 build_new_op_1
        ../../gcc-9.3.0/gcc/cp/call.c:6244
0x5acc5f build_new_op(op_location_t const&, tree_code, int, tree_node*,
tree_node*, tree_node*, tree_node**, int)
        ../../gcc-9.3.0/gcc/cp/call.c:6288
0x6db536 build_x_binary_op(op_location_t const&, tree_code, tree_node*,
tree_code, tree_node*, tree_code, tree_node**, int)
        ../../gcc-9.3.0/gcc/cp/typeck.c:4189
0x64e52c cp_parser_binary_expression
        ../../gcc-9.3.0/gcc/cp/parser.c:9624
0x64f129 cp_parser_assignment_expression
        ../../gcc-9.3.0/gcc/cp/parser.c:9759
0x64f492 cp_parser_expression
        ../../gcc-9.3.0/gcc/cp/parser.c:9926
0x673104 cp_parser_condition
        ../../gcc-9.3.0/gcc/cp/parser.c:12153
0x65d47f cp_parser_selection_statement
        ../../gcc-9.3.0/gcc/cp/parser.c:11808
0x65d47f cp_parser_statement
        ../../gcc-9.3.0/gcc/cp/parser.c:11186
0x65e410 cp_parser_statement_seq_opt
        ../../gcc-9.3.0/gcc/cp/parser.c:11667
0x65e4bf cp_parser_compound_statement
        ../../gcc-9.3.0/gcc/cp/parser.c:11621
0x67299a cp_parser_function_body
        ../../gcc-9.3.0/gcc/cp/parser.c:22703
0x67299a cp_parser_ctor_initializer_opt_and_function_body
        ../../gcc-9.3.0/gcc/cp/parser.c:22754
0x675186 cp_parser_function_definition_after_declarator
        ../../gcc-9.3.0/gcc/cp/parser.c:27883
0x675e78 cp_parser_function_definition_from_specifiers_and_declarator
        ../../gcc-9.3.0/gcc/cp/parser.c:27799
0x675e78 cp_parser_init_declarator
        ../../gcc-9.3.0/gcc/cp/parser.c:20328
Please submit a full bug report,


ga@oldell:~/gcc/avr/bin$ ./avr-g++ -v
Using built-in specs.
Reading specs from /home/ga/gcc/avr/lib/gcc/avr/9.3.0/device-specs/specs-avr2
COLLECT_GCC=./avr-g++
COLLECT_LTO_WRAPPER=/home/ga/gcc/avr/libexec/gcc/avr/9.3.0/lto-wrapper
Target: avr
Configured with: ../gcc-9.3.0/configure --target=avr --prefix=/home/ga/gcc/avr
--host=x86_64-pc-linux-gnu
Thread model: single
gcc version 9.3.0 (GCC)

[Bug target/94437] Internal compiler error in avr-g++

[gatk555 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

Giles Atkinson <gatk555 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48158|0                           |1
        is obsolete|                            |

--- Comment #7 from Giles Atkinson <gatk555 at gmail dot com> ---
Created attachment 48167
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48167&action=edit
Source code

Seek redemption for grave sin. (Restore LGPL comment)

[Bug target/94437] Internal compiler error in avr-g++

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94437

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Dup of bug 97377.

*** This bug has been marked as a duplicate of bug 97377 ***