* [Bug target/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
@ 2020-04-02 9:58 ` avieira at gcc dot gnu.org
2020-04-02 10:13 ` avieira at gcc dot gnu.org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: avieira at gcc dot gnu.org @ 2020-04-02 9:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
avieira at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |avieira at gcc dot gnu.org
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
Last reconfirmed| |2020-04-02
--- Comment #1 from avieira at gcc dot gnu.org ---
Hi Christophe,
This looks to me like an issue of not building distinct types for the ns_foo_t
and s_bar_t function types.
When I first wrote this code I tested for this and it was working, so I am
wondering whether changes have been made in the way we create types in the
c-frontend.
I am trying to find out how all this works again, its been a while...
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
2020-04-02 9:58 ` [Bug target/94445] " avieira at gcc dot gnu.org
@ 2020-04-02 10:13 ` avieira at gcc dot gnu.org
2020-04-02 11:12 ` clyon at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: avieira at gcc dot gnu.org @ 2020-04-02 10:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #2 from avieira at gcc dot gnu.org ---
start_decl seems to be doing the right thing, investigation continues...
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
2020-04-02 9:58 ` [Bug target/94445] " avieira at gcc dot gnu.org
2020-04-02 10:13 ` avieira at gcc dot gnu.org
@ 2020-04-02 11:12 ` clyon at gcc dot gnu.org
2020-04-02 11:42 ` avieira at gcc dot gnu.org
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-04-02 11:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #3 from Christophe Lyon <clyon at gcc dot gnu.org> ---
I also checked that arm_handle_cmse_nonsecure_call correctly duplicates the
type.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (2 preceding siblings ...)
2020-04-02 11:12 ` clyon at gcc dot gnu.org
@ 2020-04-02 11:42 ` avieira at gcc dot gnu.org
2020-04-02 11:43 ` avieira at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: avieira at gcc dot gnu.org @ 2020-04-02 11:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #4 from avieira at gcc dot gnu.org ---
Yeah...
So far I have checked that 'gimplify_call_expr' creates the right gimple, and
up until 'gimplify_modify_expr' I can verify it does by using
gimple_call_fntype .
Though at expansion time, the 'gimple_call_fntype (stmt)' of '_5 = s_bar_p_2(D)
(); [tail call]' now has the attribute ...
So it must go wrong somewhere between gimplification and expansion, but that's
a big window and dump files won't help us :(
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (3 preceding siblings ...)
2020-04-02 11:42 ` avieira at gcc dot gnu.org
@ 2020-04-02 11:43 ` avieira at gcc dot gnu.org
2020-04-02 12:33 ` avieira at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: avieira at gcc dot gnu.org @ 2020-04-02 11:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #5 from avieira at gcc dot gnu.org ---
Yeah...
So far I have checked that 'gimplify_call_expr' creates the right gimple, and
up until 'gimplify_modify_expr' I can verify it does by using
gimple_call_fntype .
Though at expansion time, the 'gimple_call_fntype (stmt)' of '_5 = s_bar_p_2(D)
(); [tail call]' now has the attribute ...
So it must go wrong somewhere between gimplification and expansion, but that's
a big window and dump files won't help us :(
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (4 preceding siblings ...)
2020-04-02 11:43 ` avieira at gcc dot gnu.org
@ 2020-04-02 12:33 ` avieira at gcc dot gnu.org
2020-04-02 14:03 ` [Bug ipa/94445] " marxin at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: avieira at gcc dot gnu.org @ 2020-04-02 12:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #6 from avieira at gcc dot gnu.org ---
I have also identified that this only goes wrong in O2 or higher. And it
happens sometime between tailcall optimization pass 1 and 2. But there's loads
of passes in between.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug ipa/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (5 preceding siblings ...)
2020-04-02 12:33 ` avieira at gcc dot gnu.org
@ 2020-04-02 14:03 ` marxin at gcc dot gnu.org
2020-04-03 7:05 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-04-02 14:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|target |ipa
Target Milestone|--- |10.0
Assignee|clyon at gcc dot gnu.org |marxin at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
It's ICF issue and I've got a patch for it.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug ipa/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (6 preceding siblings ...)
2020-04-02 14:03 ` [Bug ipa/94445] " marxin at gcc dot gnu.org
@ 2020-04-03 7:05 ` cvs-commit at gcc dot gnu.org
2020-04-03 7:07 ` marxin at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-03 7:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:55a7380213a5c16120d5c674fb42b38a3d796b57
commit r10-7530-g55a7380213a5c16120d5c674fb42b38a3d796b57
Author: Martin Liska <mliska@suse.cz>
Date: Fri Apr 3 09:05:06 2020 +0200
ICF: compare type attributes for gimple_call_fntypes.
PR ipa/94445
* ipa-icf-gimple.c (func_checker::compare_gimple_call):
Compare type attributes for gimple_call_fntypes.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug ipa/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (7 preceding siblings ...)
2020-04-03 7:05 ` cvs-commit at gcc dot gnu.org
@ 2020-04-03 7:07 ` marxin at gcc dot gnu.org
2020-04-03 10:34 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-04-03 7:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
Known to fail| |8.4.0, 9.3.0
Known to work| |10.0
--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed on master, I'll backport that.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug ipa/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (8 preceding siblings ...)
2020-04-03 7:07 ` marxin at gcc dot gnu.org
@ 2020-04-03 10:34 ` cvs-commit at gcc dot gnu.org
2020-04-03 10:37 ` cvs-commit at gcc dot gnu.org
2020-04-03 10:39 ` marxin at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-03 10:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:69df6742cb4e15fba5ee074629a78811e61f044d
commit r9-8447-g69df6742cb4e15fba5ee074629a78811e61f044d
Author: Martin Liska <mliska@suse.cz>
Date: Fri Apr 3 12:33:41 2020 +0200
Backport 55a7380213a5c16120d5c674fb42b38a3d796b57
Backport from mainline
2020-04-03 Martin Liska <mliska@suse.cz>
PR ipa/94445
* ipa-icf-gimple.c (func_checker::compare_gimple_call):
Compare type attributes for gimple_call_fntypes.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug ipa/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (9 preceding siblings ...)
2020-04-03 10:34 ` cvs-commit at gcc dot gnu.org
@ 2020-04-03 10:37 ` cvs-commit at gcc dot gnu.org
2020-04-03 10:39 ` marxin at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-03 10:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:33c5b217cbc7562238f96a29393f6ca8fb97482a
commit r8-10161-g33c5b217cbc7562238f96a29393f6ca8fb97482a
Author: Martin Liska <mliska@suse.cz>
Date: Fri Apr 3 12:36:31 2020 +0200
Backport 55a7380213a5c16120d5c674fb42b38a3d796b57
Backport from mainline
2020-04-03 Martin Liska <mliska@suse.cz>
PR ipa/94445
* ipa-icf-gimple.c (func_checker::compare_gimple_call):
Compare type attributes for gimple_call_fntypes.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug ipa/94445] gcc.target/arm/cmse/cmse-15.c fails for cortex-m33
2020-04-01 15:55 [Bug target/94445] New: gcc.target/arm/cmse/cmse-15.c fails for cortex-m33 clyon at gcc dot gnu.org
` (10 preceding siblings ...)
2020-04-03 10:37 ` cvs-commit at gcc dot gnu.org
@ 2020-04-03 10:39 ` marxin at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-04-03 10:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94445
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
Known to fail|8.4.0, 9.3.0 |
Known to work| |8.4.1, 9.3.1
--- Comment #12 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed on active branches.
^ permalink raw reply [flat|nested] 13+ messages in thread