public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nathan at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/94454] ICE 'canonical types differ for identical types'
Date: Tue, 14 Apr 2020 17:30:52 +0000	[thread overview]
Message-ID: <bug-94454-4-6xuBfCkkOx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94454-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94454

--- Comment #12 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
Created attachment 48270
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48270&action=edit
asserts to trigger it

I have found the cause, but not the underlying reason.  We have template
arguments that compare equal but hash differently.  So the earlier attempts to
cause hash collisions by neutering the hasher, made the bug go away.
This patch neuters the hasher, but adds an assert into the argyment comparator
-- if the args compare equal, they better hash equal.
This triggers on the testcase with a pair of template_id_exprs.

  parent reply	other threads:[~2020-04-14 17:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 12:28 [Bug c++/94454] New: " iains at gcc dot gnu.org
2020-04-02 12:28 ` [Bug c++/94454] " iains at gcc dot gnu.org
2020-04-02 12:38 ` iains at gcc dot gnu.org
2020-04-02 12:44 ` jakub at gcc dot gnu.org
2020-04-02 12:45 ` jakub at gcc dot gnu.org
2020-04-02 13:00 ` nathan at gcc dot gnu.org
2020-04-02 16:37 ` iains at gcc dot gnu.org
2020-04-02 16:50 ` nathan at acm dot org
2020-04-02 18:19 ` iains at gcc dot gnu.org
2020-04-02 18:40 ` iains at gcc dot gnu.org
2020-04-02 19:48 ` iains at gcc dot gnu.org
2020-04-13 19:13 ` nathan at gcc dot gnu.org
2020-04-13 19:24 ` iains at gcc dot gnu.org
2020-04-14 17:30 ` nathan at gcc dot gnu.org [this message]
2020-04-14 17:36 ` nathan at gcc dot gnu.org
2020-04-20 13:55 ` nathan at gcc dot gnu.org
2020-04-20 13:56 ` nathan at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94454-4-6xuBfCkkOx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).