public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/94470] [8/9/10 Regression] Constexpr variable initialization with self-modifying constructor incorrectly rejected since r7-6728 Date: Mon, 13 Apr 2020 21:04:48 +0000 [thread overview] Message-ID: <bug-94470-4-nLMy0tE3t1@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-94470-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94470 --- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:077dd9b3f17710da8af6adce816754ddceb57b5a commit r10-7704-g077dd9b3f17710da8af6adce816754ddceb57b5a Author: Patrick Palka <ppalka@redhat.com> Date: Mon Apr 13 16:53:02 2020 -0400 c++: More self-modifying constexpr init [PR94470] In this PR we're incorrectly rejecting a self-modifying constexpr initializer as a consequence of the fix for PR78572. It looks like however that the fix for PR78572 is obsoleted by the fix for PR89336: the testcase from the former PR successfully compiles even with its fix reverted. But then further testing showed that the analogous testcase of PR78572 where the array has an aggregate element type is still problematic (i.e. we ICE) even with the fix for PR78572 applied. The reason is that in cxx_eval_bare_aggregate we attach a constructor_elt of aggregate type always to the end of the new CONSTRUCTOR, but that's not necessarily correct if the CONSTRUCTOR is self-modifying. We should instead be using get_or_insert_ctor_field to insert the constructor_elt in the right place. So this patch reverts the PR78572 fix and makes the appropriate changes to cxx_eval_bare_aggregate. This fixes PR94470, and we now are also able to fully reduce the initializers of 'arr' and 'arr2' in the new test array57.C to constant initializers. gcc/cp/ChangeLog: PR c++/94470 * constexpr.c (get_or_insert_ctor_field): Set default value of parameter 'pos_hint' to -1. (cxx_eval_bare_aggregate): Use get_or_insert_ctor_field instead of assuming the the next index belongs at the end of the new CONSTRUCTOR. (cxx_eval_store_expression): Revert PR c++/78572 fix. gcc/testsuite/ChangeLog: PR c++/94470 * g++.dg/cpp1y/constexpr-nsdmi8.C: New test. * g++.dg/cpp1y/constexpr-nsdmi9.C: New test. * g++.dg/init/array57.C: New test.
next prev parent reply other threads:[~2020-04-13 21:04 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-03 13:43 [Bug c++/94470] New: " ppalka at gcc dot gnu.org 2020-04-03 13:53 ` [Bug c++/94470] [8/9/10 Regression] " ppalka at gcc dot gnu.org 2020-04-03 13:57 ` mpolacek at gcc dot gnu.org 2020-04-03 13:57 ` mpolacek at gcc dot gnu.org 2020-04-13 12:11 ` ppalka at gcc dot gnu.org 2020-04-13 21:04 ` cvs-commit at gcc dot gnu.org [this message] 2020-04-13 21:06 ` [Bug c++/94470] [8/9 " ppalka at gcc dot gnu.org 2021-05-14 9:53 ` [Bug c++/94470] [9 " jakub at gcc dot gnu.org 2021-06-01 8:17 ` rguenth at gcc dot gnu.org 2022-05-27 8:51 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-94470-4-nLMy0tE3t1@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).